Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input.password doesn't have scale prop #645

Closed
so1ve opened this issue Oct 19, 2021 · 1 comment · Fixed by #685
Closed

input.password doesn't have scale prop #645

so1ve opened this issue Oct 19, 2021 · 1 comment · Fixed by #685
Assignees
@unix
Labels
type: bug Something isn't working

Comments

@so1ve
Copy link
Contributor

so1ve commented Oct 19, 2021 •
edited
Loading

Bug report 🐞

Version & Environment

  • Version of browser
  • Version of geist-ui/react latest

Expected Behaviour

No type errors

Actual results (or Errors)

I got an error:

<Input.Password scale={4/3} />

It throws a type error
so1ve added a commit to dolan-x/dolan-client-simple that referenced this issue Oct 19, 2021
@so1ve
fix(type): geist-ui
a312f50 
Input.Password has no type definition for prop "scale"

geist-org/geist-ui#645
@unix unix added the type: bug Something isn't working label Jan 11, 2022
@unix unix self-assigned this Jan 11, 2022
@unix unix pinned this issue Jan 11, 2022
@unix unix linked a pull request Jan 25, 2022 that will close this issue
feat: add scale to password component #685
Merged
2 tasks
@unix
Copy link
Member

unix commented Feb 8, 2022

Fixed in v2.3.0.

@unix unix closed this as completed Feb 8, 2022
@unix unix unpinned this issue Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unix unix

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add scale to password component
2 participants
@unix @so1ve