Issue #24: Update Molecule test suite to 3.0 and fix YAML lint issues.

.ansible-lint

@@ -0,0 +1,7 @@
+skip_list:
+  - '306'
+  - '602'
+  - '503'
+
+exclude_paths:
+  - deploy/

.github/FUNDING.yml

@@ -1,4 +1,4 @@
 # These are supported funding model platforms
-
+---
 github: geerlingguy
 patreon: geerlingguy

.travis.yml

@@ -3,7 +3,7 @@ services: docker
 language: python
 
 install:
-  - pip3 install docker molecule openshift jmespath
+  - pip3 install docker molecule yamllint ansible-lint openshift jmespath
 
 script:
   - molecule test -s test-local

.yamllint

@@ -0,0 +1,7 @@
+---
+extends: default
+rules:
+  truthy: disable
+  line-length:
+    max: 160
+    level: warning

README.md

@@ -121,7 +121,7 @@ Each of these must be appropriately built in preparation for a new tag:
 
 Run the following command inside this directory:
 
-    operator-sdk build geerlingguy/tower-operator:0.2.1
+    operator-sdk build geerlingguy/tower-operator:0.2.3
 
 Then push the generated image to Docker Hub:
 

build/chain-operator-files.yml

@@ -22,7 +22,7 @@
       blockinfile:
         path: "{{ operator_file_path }}"
         block: "{{ item }}"
-        marker: "---"
+        marker: ""
         marker_begin: ""
         marker_end: ""
         insertafter: "EOF"

deploy/crds/tower_v1alpha1_tower_cr_awx.yaml

@@ -1,3 +1,4 @@
+---
 apiVersion: tower.ansible.com/v1alpha1
 kind: Tower
 metadata:

deploy/crds/tower_v1alpha1_tower_cr_tower.yaml

@@ -1,3 +1,4 @@
+---
 apiVersion: tower.ansible.com/v1alpha1
 kind: Tower
 metadata:

deploy/crds/tower_v1alpha1_tower_crd.yaml

@@ -1,3 +1,4 @@
+---
 apiVersion: apiextensions.k8s.io/v1beta1
 kind: CustomResourceDefinition
 metadata:
@@ -14,6 +15,6 @@ spec:
     status: {}
   version: v1alpha1
   versions:
-  - name: v1alpha1
-    served: true
-    storage: true
+    - name: v1alpha1
+      served: true
+      storage: true

deploy/operator.yaml

@@ -1,3 +1,4 @@
+---
 apiVersion: apps/v1
 kind: Deployment
 metadata:
@@ -16,21 +17,21 @@ spec:
       containers:
         - name: ansible
           command:
-          - /usr/local/bin/ao-logs
-          - /tmp/ansible-operator/runner
-          - stdout
+            - /usr/local/bin/ao-logs
+            - /tmp/ansible-operator/runner
+            - stdout
           image: "{{ operator_image }}"
           imagePullPolicy: "{{ pull_policy|default('Always') }}"
           volumeMounts:
-          - mountPath: /tmp/ansible-operator/runner
-            name: runner
-            readOnly: true
+            - mountPath: /tmp/ansible-operator/runner
+              name: runner
+              readOnly: true
         - name: operator
           image: "{{ operator_image }}"
           imagePullPolicy: "{{ pull_policy|default('Always') }}"
           volumeMounts:
-          - mountPath: /tmp/ansible-operator/runner
-            name: runner
+            - mountPath: /tmp/ansible-operator/runner
+              name: runner
           env:
             # Watch all namespaces (cluster-scoped).
             - name: WATCH_NAMESPACE
@@ -41,8 +42,6 @@ spec:
                   fieldPath: metadata.name
             - name: OPERATOR_NAME
               value: tower-operator
-            # - name: ANSIBLE_VERBOSITY
-            #   value: '3'
       volumes:
         - name: runner
           emptyDir: {}

deploy/role.yaml

@@ -1,64 +1,65 @@
+---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
   creationTimestamp: null
   name: tower-operator
 rules:
-- apiGroups:
-  - ""
-  resources:
-  - pods
-  - services
-  - services/finalizers
-  - endpoints
-  - persistentvolumeclaims
-  - events
-  - configmaps
-  - secrets
-  verbs:
-  - '*'
-- apiGroups:
-  - apps
-  - extensions
-  resources:
-  - deployments
-  - daemonsets
-  - replicasets
-  - statefulsets
-  - ingresses
-  verbs:
-  - '*'
-- apiGroups:
-  - monitoring.coreos.com
-  resources:
-  - servicemonitors
-  verbs:
-  - get
-  - create
-- apiGroups:
-  - apps
-  resourceNames:
-  - tower-operator
-  resources:
-  - deployments/finalizers
-  verbs:
-  - update
-- apiGroups:
-  - ""
-  resources:
-  - pods/exec
-  verbs:
-  - create
-  - get
-- apiGroups:
-  - apps
-  resources:
-  - replicasets
-  verbs:
-  - get
-- apiGroups:
-  - tower.ansible.com
-  resources:
-  - '*'
-  verbs:
-  - '*'
+  - apiGroups:
+      - ""
+    resources:
+      - pods
+      - services
+      - services/finalizers
+      - endpoints
+      - persistentvolumeclaims
+      - events
+      - configmaps
+      - secrets
+    verbs:
+      - '*'
+  - apiGroups:
+      - apps
+      - extensions
+    resources:
+      - deployments
+      - daemonsets
+      - replicasets
+      - statefulsets
+      - ingresses
+    verbs:
+      - '*'
+  - apiGroups:
+      - monitoring.coreos.com
+    resources:
+      - servicemonitors
+    verbs:
+      - get
+      - create
+  - apiGroups:
+      - apps
+    resourceNames:
+      - tower-operator
+    resources:
+      - deployments/finalizers
+    verbs:
+      - update
+  - apiGroups:
+      - ""
+    resources:
+      - pods/exec
+    verbs:
+      - create
+      - get
+  - apiGroups:
+      - apps
+    resources:
+      - replicasets
+    verbs:
+      - get
+  - apiGroups:
+      - tower.ansible.com
+    resources:
+      - '*'
+    verbs:
+      - '*'

deploy/role_binding.yaml

@@ -1,11 +1,12 @@
+---
 kind: ClusterRoleBinding
 apiVersion: rbac.authorization.k8s.io/v1
 metadata:
   name: tower-operator
 subjects:
-- kind: ServiceAccount
-  name: tower-operator
-  namespace: default
+  - kind: ServiceAccount
+    name: tower-operator
+    namespace: default
 roleRef:
   kind: ClusterRole
   name: tower-operator

deploy/service_account.yaml

@@ -1,3 +1,4 @@
+---
 apiVersion: v1
 kind: ServiceAccount
 metadata: