-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Helmet v5, add include
/exclude
support, fix express 200.html rendering, only crawl potential html pages
#24
Conversation
Also various other bugs I found * Fixes #19 Saving subroutes * Clean up path config option * Add support for excluding files * Fixes problems with a basename (related to #15, #16) * package.json only read once now * only crawl potential html pages (not links to .jpg files for instance) * Fix Server so that it renders 200.html if a file was not found * Release resources so that the server can gracefully shutdown * Removed hardcoded port * Updated readme
Add proxying support
…into haroldhues-master Conflicts: package.json src/Crawler.js src/Server.js src/cli.js src/snapshot.js
Hey! Thanks for this! I'd actually done a little bit of work myself on a few of those, but hadn't finished and merged it. I've just done so now at #26 There were a few merge conflicts but I've fixed them and pushed the code on the Very keen to get a new release out with these changes in the next few days. Thanks again for picking up a bunch of things at once 👌 |
I couldn't get it to work for my use case, might be that it didn't work with a mountpath?
@geelen Path problem is fixed, I could not get BTW |
Closing in favour of #27 |
Boom. Finally figured out the bugs with this, and have merged & published |
Apologies, it seems I have put a lot into this PR. I was kind of on a roll though. I tried to test as many configurations as I could and it seems pretty stable.
Note: I went ahead and renamed the
path
option toinclude
since it wasnt documented and it appears react-snapshot hasn
t been released yet. But I can make that backward compatible as well...Fixes #17
Fixes #19
Incorporated #23 and #22
Fixes #15 and #16 in a few more cases, also handles includes and excludes for basenames
Closes #11
Also various other things I found