Refactored and Optimised Code base #1699
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactored master branch
OfficialAhmed
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
sum(d_cards) is not evaluated. It should be evaluated and
Sum of both d_cards & p_cards should equal to 21
There was a problem hiding this comment.
- Removing comments not a good idea as its not enhancing the code in any way unless
- One way to factor this block of code is to assign
input_str[-2]to a variable, this way its more readable hence the comments are no longer needed 👍
There was a problem hiding this comment.
match-case is faster than if-else. If you could do that instead of the if-else
match choice:
case "1":
...
case _:
...
There was a problem hiding this comment.
yes, @OfficialAhmed is right.
Match case are being introduced in not but recent version of python.
They are somewhat new in to this language.
OfficialAhmed
approved these changes
Jul 27, 2023
OfficialAhmed
approved these changes
Jul 27, 2023
DiodDan
reviewed
Nov 1, 2023
Comment on lines
52
to
53
| else: | ||
| continue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized all code bases and refactored code.