-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default the layer manager to be opened on map initialization and other toolbar tweaks #2039
Default the layer manager to be opened on map initialization and other toolbar tweaks #2039
Conversation
I am aware of this issue. It is related to ipyevents. I believe it does not support Colab. Need some investigation.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add unit tests if it's not too much trouble?
No trouble at all! Done. |
Gotcha, thanks for raising that! I'm leaning towards removing the hover effect for two reasons: 1) it's highly susceptible for jitter, and 2) it only opens the toolbar on hover since it would be hard to detect which button is being hovered (can use pixel calculations maybe?), so it might feel weird to users that only one of the two buttons are openable on hover, if that makes sense. LMK what you prefer! |
@sufyanAbbasi Makes sense. Let's remove the hovering effect. We can potentially remove the ipyevent dependency completely after removing the hovering effect on the data search button in the upper-left corner. I can do that in another PR. |
On it!
Ah, good eye! Let me figure out what's going on there. |
Removed the hover effect and also figured out why the toolbar flickered in like that: we need to have the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! It works as expected now. No more flickering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
See: https://colab.research.google.com/drive/1HHQomXhy-vS68qiMu6AOhDmrsLq6OZwe#scrollTo=IouG0AzwPFID