Add default decoder for anonymous record types to BasicTypeRegistry #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbandy
approved these changes
Aug 11, 2024
The PostgreSQL server just sends the generic OID 2249 for generic record/composite types in query results like:
SELECT row(123, 'str', true, null)
Since we don't get the OIDs of the record items, we can not properly decode them.
Nevertheless it's helpful to decode at least with the default type map and decode all items to an array of strings like so:
c.exec("SELECT 6, row(123, 'str', true, null), 7").values
=> [[6, ["123", "str", "t", nil], 7]]
instead of:
=> [[6, "(123,str,t,)", 7]]
Related to ged#578
larskanis
force-pushed
the
add-record-to-btm
branch
from
ecd0624
to
761b272
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PostgreSQL server just sends the generic OID 2249 for generic record/composite types in query results like:
Since we don't get the OIDs of the record items, we can not properly decode them. Nevertheless it's helpful to decode at least with the default type map and decode all items to an array of strings like so:
instead of:
Related to #578