Fix typos #566
Merged
Fix typos #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larskanis
requested changes
Apr 26, 2024
lib/pg/basic_type_registry.rb
Outdated
| @@ -207,12 +207,12 @@ def register_type(format, name, encoder_class, decoder_class) | |||
|
|
|||
| # Alias the +old+ type to the +new+ type. | |||
| def alias_type(format, new, old) | |||
| [:encoder, :decoder].each do |ende| | |||
There was a problem hiding this comment.
ende means encoder-decoder in this context. It is no spelling mistake.
|
Thank you very much for scanning and correction! It's all OK with the exception of ende->end. |
|
Nice - thank you! |
cbandy
reviewed
Apr 26, 2024
| @@ -543,7 +543,7 @@ Init_pg_ext(void) | |||
| /* Result#result_error_field argument constant | |||
| * | |||
| * The SQLSTATE code for the error. | |||
| * The SQLSTATE code identies the type of error that has occurred; it can be used by front-end applications to perform specific operations (such as error handling) in response to a particular database error. | |||
| * The SQLSTATE code identities the type of error that has occurred; it can be used by front-end applications to perform specific operations (such as error handling) in response to a particular database error. | |||
| @@ -171,7 +171,7 @@ module Checker | |||
| include Checker | |||
|
|
|||
| def initialize | |||
| # The key of these hashs maps to the `typname` column from the table pg_type. | |||
| # The key of these hashes maps to the `typname` column from the table pg_type. | |||
There was a problem hiding this comment.
I opened #567 to better describe the content of @coders_by_name. Is it OK?
larskanis
added a commit
to larskanis/ruby-pg
that referenced
this pull request
Apr 26, 2024
As suggested in ged#566 (review)
|
🥳 🥳 🥳 🥳 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via
codespell -L te,wronly,noes,nulllandtypos --format brief