Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PG::Connection#check_connection as a way to verify the socket is OK #521

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

larskanis
Copy link
Collaborator

... without data exchange with the server.

Related to #509

lib/pg/connection.rb Outdated Show resolved Hide resolved
Copy link
Owner

@ged ged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The suggestion from @mt-clearhaus looks good too.

... without data exchange with the server.

Related to ged#509
@larskanis larskanis merged commit ce8b2cf into ged:master Apr 20, 2023
@larskanis larskanis deleted the check_connection branch April 20, 2023 06:14
@larskanis
Copy link
Collaborator Author

I wonder if check_connection is the best name, as it sounds like a connection round trip is done. Maybe check_socket is better. What do you think?

@cbandy
Copy link
Contributor

cbandy commented Apr 20, 2023

Agreed. I like check_socket.

@ged
Copy link
Owner

ged commented Apr 20, 2023

Yeah, check_socket is much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants