Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binary COPY encoders and decoders and binary timestamp encoders #511

Merged
merged 13 commits into from
Mar 24, 2023
Merged

Add binary COPY encoders and decoders and binary timestamp encoders #511

merged 13 commits into from
Mar 24, 2023

Conversation

larskanis
Copy link
Collaborator

@larskanis larskanis commented Mar 21, 2023 •
edited
Loading

To be useful more binary encoders are desirable. This is why they are added as well.

  • Add COPY encoder
  • Add COPY decoder
  • Add timestamp encoder
  • Add float encoder
  • Add numeric encoder (not done now -> something for later)
  • Add tests for invalid data to be decoded (and that it doesn't segfault)
  • Add special case of "Infinity" to timestamp encoder

@larskanis
Add PG::Result#binary_tuples
cff24d0 
It is useful for COPY and not deprecated in that context.
@larskanis
Add binary timestamp encoders:
69ac30c 
* PG::BinaryEncoder::TimestampUtc
* PG::BinaryEncoder::TimestampLocal
* PG::BinaryEncoder::Timestamp
larskanis and others added 10 commits March 24, 2023 11:11
@larskanis
Add binary COPY encoder and decoder:
4bd81df 
* PG::BinaryEncoder::CopyRow
* PG::BinaryDecoder::CopyRow
@larskanis
Improve CopyCoder documentation a bit
03bd178
@larskanis
Use keyword arguments instead of hashes for Coder initialization and …
fd8bdbb 
…to_h
@larskanis
Include BinaryFormatting only once to fix Truffleruby
8aca50a 
BinaryFormatting is already included by pg_define_coder() in case of BinaryEncoder::CopyRow.
Including BinaryFormatting twice resulted into an endless recursion by the PG::Coder#super call on Truffleruby.
@larskanis
Add PG::BinaryEncoder::Float4 and Float8
787c7fc
@larskanis
Fix BinaryDecoder::CopyRow regarding negative binary lengths
1be50d7 
They bypassed input size checks and produced segfaults.
@larskanis
Add type specs for binary CopyRow en-/decoders
1282200
@larskanis
Describe the use of the return value of fit_to_copy_get
e423ab3
@larskanis
Add BinaryEncoder::Float4 and Float8 to the README
0de9cc7
@larskanis
Use exponent of 3 digits to fix compatibility issue with older Postgr…
e23692d 
…eSQL server
@larskanis
Add special case of infinity/-infinity to binary timestamp encoder
bae9a50 
And enable text format in addition to binary in specs for comparison.
@larskanis larskanis merged commit c83e7fe into ged:master Mar 24, 2023
@larskanis larskanis deleted the binary-copy branch March 24, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@larskanis