Update CI and improve discard_results
#500
Merged
+139
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows ruby-3.1 is needed.
Just to be safe, since x86-mingw32 is a bit slower. It takes approx 30 seconds on my Laptop with Windows in qemu-kvm.
.. in the busy loop and after PQputCopyEnd.
This blocked on ruby-3.1 on x86-mingw32 like so:
1) PG::Connection in nonblocking mode rejects to send lots of COPY data
Failure/Error: raise("scheduler timeout in:\n#{th.backtrace.join("\n")}")
RuntimeError:
scheduler timeout in:
D:/a/ruby-pg/ruby-pg/spec/pg/connection_spec.rb:666:in `discard_results'
D:/a/ruby-pg/ruby-pg/spec/pg/connection_spec.rb:666:in `block (4 levels) in <top (required)>'
D:/a/ruby-pg/ruby-pg/spec/helpers.rb:645:in `block in run_with_gate'
D:/a/ruby-pg/ruby-pg/spec/helpers.rb:602:in `block in thread_with_timeout'
./spec/helpers.rb:607:in `thread_with_timeout'
./spec/helpers.rb:641:in `run_with_gate'
./spec/pg/connection_spec.rb:645:in `block (3 levels) in <top (required)>'
./spec/helpers.rb:55:in `block in included'
Experimentation showed that under memory pressure PQflush, PQconsumeInput and PQgetResult must be called in combination to not block infinitely.
Separate loops for PQflush+PQconsumeInput and PQgetResult+PQconsumeInput don't work and often result in starvation on Github-Actions on x86-mingw32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates CI on Appveyor and Github Actions and adds a test of the binary gems for x86-mingw32.
Adding the platform x86-mingw32 showed that there can be issues with
discard_resultsgetting into starvation under memory pressure. So the second half of commits improvediscard_resultsbehavior, documentation and specs.