Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nonblocking mode while large object calls #498

Merged
merged 1 commit into from
Feb 23, 2023

Commits on Feb 23, 2023

  1. Disable nonblocking mode while large object calls

    libpq's "lo_*" calls fail when a bigger amount of data is transferred and the connection is set to nonblocking mode.
    According to some discussion here
      https://www.postgresql.org/message-id/20130606.082048.998330612674120762.t-ishii%40sraoss.co.jp
    the large object interface isn't intended to be used with nonblocking mode.
    
    It works to some extend with small data (< 8000 Bytes), but fails after lo_write of bigger data at the next exec call on the same connection like so:
    ```
    message type 0x56 arrived from server while idle
    message type 0x5a arrived from server while idle
    message type 0x43 arrived from server while idle
    message type 0x5a arrived from server while idle
    PG::UnableToSend: unexpected response from server; first received character was "V"
    ```
    
    I think the best solution is to disable nonblocking mode for the time of the lo_* call.
    Calling PQisnonblocking and PQsetnonblocking is very low overhead, since these functions do a few memory operations only.
    
    Fixes ged#460
    larskanis committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    dba5322 View commit details
    Browse the repository at this point in the history