Allow PG::Error to be created without arguments #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not used in our code, but some users do this and it used to work in pg<1.4.0. Fixes ged#466
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jun 23, 2022
pg 1.4.0 was released with a breaking change to the interface for the PG::Error class: ged/ruby-pg@91b00d0 It was repored in ged/ruby-pg#466 and fixed in ged/ruby-pg#467 but not yet released. 1.4.0 was breaking our pg logical spec as seen below 1) PglogicalSubscription#backlog returns nil if error raised inside Failure/Error: MiqRegionRemote.with_remote_connection(host, port || 5432, user, decrypted_password, dbname, "postgresql", connect_timeout) do |conn| yield conn end ArgumentError: wrong number of arguments (given 0, expected 1) # ./app/models/pglogical_subscription.rb:294:in `with_remote_connection' # ./app/models/pglogical_subscription.rb:289:in `remote_region_lsn' # ./app/models/pglogical_subscription.rb:104:in `backlog' # ./spec/models/pglogical_subscription_spec.rb:495:in `block (3 levels) in <top (required)>'
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jun 23, 2022
pg 1.4.0 was released with a breaking change to the interface for the PG::Error class: ged/ruby-pg@91b00d0 It was reported in ged/ruby-pg#466 and fixed in ged/ruby-pg#467 but not yet released. 1.4.0 was breaking our pg logical spec as seen below 1) PglogicalSubscription#backlog returns nil if error raised inside Failure/Error: MiqRegionRemote.with_remote_connection(host, port || 5432, user, decrypted_password, dbname, "postgresql", connect_timeout) do |conn| yield conn end ArgumentError: wrong number of arguments (given 0, expected 1) # ./app/models/pglogical_subscription.rb:294:in `with_remote_connection' # ./app/models/pglogical_subscription.rb:289:in `remote_region_lsn' # ./app/models/pglogical_subscription.rb:104:in `backlog' # ./spec/models/pglogical_subscription_spec.rb:495:in `block (3 levels) in <top (required)>'
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Jun 24, 2022
1.4.0 led to ged/ruby-pg#466 and was fixed in ged/ruby-pg#467 Since 1.4.1 is now released and fixes the issue, we can safely unlock pg except for version 1.4.0.
iv1111
pushed a commit
to iv1111/manageiq
that referenced
this pull request
Jun 28, 2022
pg 1.4.0 was released with a breaking change to the interface for the PG::Error class: ged/ruby-pg@91b00d0 It was reported in ged/ruby-pg#466 and fixed in ged/ruby-pg#467 but not yet released. 1.4.0 was breaking our pg logical spec as seen below 1) PglogicalSubscription#backlog returns nil if error raised inside Failure/Error: MiqRegionRemote.with_remote_connection(host, port || 5432, user, decrypted_password, dbname, "postgresql", connect_timeout) do |conn| yield conn end ArgumentError: wrong number of arguments (given 0, expected 1) # ./app/models/pglogical_subscription.rb:294:in `with_remote_connection' # ./app/models/pglogical_subscription.rb:289:in `remote_region_lsn' # ./app/models/pglogical_subscription.rb:104:in `backlog' # ./spec/models/pglogical_subscription_spec.rb:495:in `block (3 levels) in <top (required)>'
iv1111
pushed a commit
to iv1111/manageiq
that referenced
this pull request
Jun 28, 2022
1.4.0 led to ged/ruby-pg#466 and was fixed in ged/ruby-pg#467 Since 1.4.1 is now released and fixes the issue, we can safely unlock pg except for version 1.4.0.
GilbertCherrie
pushed a commit
to GilbertCherrie/manageiq
that referenced
this pull request
Jul 7, 2023
pg 1.4.0 was released with a breaking change to the interface for the PG::Error class: ged/ruby-pg@91b00d0 It was reported in ged/ruby-pg#466 and fixed in ged/ruby-pg#467 but not yet released. 1.4.0 was breaking our pg logical spec as seen below 1) PglogicalSubscription#backlog returns nil if error raised inside Failure/Error: MiqRegionRemote.with_remote_connection(host, port || 5432, user, decrypted_password, dbname, "postgresql", connect_timeout) do |conn| yield conn end ArgumentError: wrong number of arguments (given 0, expected 1) # ./app/models/pglogical_subscription.rb:294:in `with_remote_connection' # ./app/models/pglogical_subscription.rb:289:in `remote_region_lsn' # ./app/models/pglogical_subscription.rb:104:in `backlog' # ./spec/models/pglogical_subscription_spec.rb:495:in `block (3 levels) in <top (required)>'
GilbertCherrie
pushed a commit
to GilbertCherrie/manageiq
that referenced
this pull request
Jul 7, 2023
1.4.0 led to ged/ruby-pg#466 and was fixed in ged/ruby-pg#467 Since 1.4.1 is now released and fixes the issue, we can safely unlock pg except for version 1.4.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not used in our code, but some users do this and it used to work in pg<1.4.0.
Fixes #466