Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BigDecimal to gemspec for Ruby 3.3/4 #569

Closed
womblep opened this issue May 15, 2024 · 2 comments · Fixed by #574
Closed

Add BigDecimal to gemspec for Ruby 3.3/4 #569

womblep opened this issue May 15, 2024 · 2 comments · Fixed by #574

Comments

@womblep
Copy link

womblep commented May 15, 2024

Ruby 3.3 displays a warning when using pg-1.5.6

/usr/local/bundle/gems/pg-1.5.6/lib/pg/basic_type_registry.rb:229: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of pg-1.5.6 to add bigdecimal into its gemspec.
@larskanis
Copy link
Collaborator

This is already fixed by #556

@womblep
Copy link
Author

womblep commented May 15, 2024

@larskanis great! I couldnt find an issue mentioning BigDecimal, I didnt look in PRs.
Any idea when the next Gem will come out with this fix?

larskanis added a commit to larskanis/ruby-pg that referenced this issue Jul 28, 2024
@larskanis
Don't print a warning when bigdecimal is required on ruby-3.4+
a629d14 
Ruby-3.4+ prints a warning, if bigdecimal is required but not in the Gemfile.
But it's a false positive, since we enable bigdecimal depending features only if it's available.
And most people don't need these features.

Fixes ged#569
@larskanis larskanis mentioned this issue Jul 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't print a warning when bigdecimal is required on ruby-3.4+ larskanis/ruby-pg
2 participants
@larskanis @womblep