Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected vignettes + script to produce paper plots and results. #163

Merged
merged 11 commits into from
Aug 18, 2023

Conversation

pepaaran
Copy link
Collaborator

@pepaaran pepaaran commented Aug 6, 2023

The PR includes:

  • Remove chain autocorrelation part in sensitivity analysis vignette.
  • Bug fix in P-model use vignette (calibration result was hard coded for speed but not updated to match data without the year 2014, now updated).
  • New script in analysis/paper_results.R to produce figures and RMSE results in the paper, even after vignettes are modified in the future.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (bd02f11) 93.53% compared to head (045c195) 93.53%.
Report is 7 commits behind head on master.

❗ Current head 045c195 differs from pull request most recent head 98fa056. Consider uploading reports for the commit 98fa056 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #163   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          12       12           
  Lines        1083     1083           
=======================================
  Hits         1013     1013           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stineb
Copy link
Collaborator

stineb commented Aug 9, 2023

@pepaaran , one test fails, therefore I haven't merged this PR.

@pepaaran
Copy link
Collaborator Author

pepaaran commented Aug 9, 2023

It's a segmentation fault error that gets triggered sometimes (and quite randomly, also from ubuntu to mac system) with the \dontrun examples in the BiomeE documentation. I have no idea how to fix it (and spent some time on it), but it's been there for a long time and previous versions of the master branch. Any help is welcome.

Copy link
Collaborator

@stineb stineb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Thanks @pepaaran

@stineb stineb merged commit efa500e into geco-bern:master Aug 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants