-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected vignettes + script to produce paper plots and results. #163
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 12 12
Lines 1083 1083
=======================================
Hits 1013 1013
Misses 70 70 ☔ View full report in Codecov by Sentry. |
@pepaaran , one test fails, therefore I haven't merged this PR. |
It's a segmentation fault error that gets triggered sometimes (and quite randomly, also from ubuntu to mac system) with the \dontrun examples in the BiomeE documentation. I have no idea how to fix it (and spent some time on it), but it's been there for a long time and previous versions of the master branch. Any help is welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. Thanks @pepaaran
The PR includes:
analysis/paper_results.R
to produce figures and RMSE results in the paper, even after vignettes are modified in the future.