Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sandbox): use sp-wasm-interface-common instead of sp-wasm-interface #3603

Merged
merged 6 commits into from
Dec 22, 2023
Merged

chore(sandbox): use sp-wasm-interface-common instead of sp-wasm-interface #3603

merged 6 commits into from
Dec 22, 2023

Conversation

clearloop
Copy link
Contributor

we have sp-wasm-interface-common as the dependency of sp-wasm-interface, in the implementation of sandbox-host and sandbox-env, we are actually just using the modules from sp-wasm-interface-common, so use -common instead of sp-wasm-interface.

  • switch to -common in sandbox-host
  • switch to -common in sandbox-env

@gear-tech/dev

@clearloop clearloop mentioned this pull request Dec 18, 2023
Merged
8 tasks
@clearloop clearloop marked this pull request as ready for review December 18, 2023 15:28
@clearloop clearloop added the A0-pleasereview PR is ready to be reviewed by the team label Dec 18, 2023
clearloop
clearloop commented Dec 18, 2023
View reviewed changes
scripts/src/test.sh Outdated Show resolved Hide resolved
gshep
gshep approved these changes Dec 19, 2023
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
sandbox/host/src/util.rs Outdated Show resolved Hide resolved
breathx
breathx approved these changes Dec 19, 2023
View reviewed changes
sandbox/host/src/util.rs Outdated Show resolved Hide resolved
@clearloop clearloop requested review from gshep, ukint-vs and breathx and removed request for ukint-vs December 19, 2023 21:21
@breathx breathx added the A2-mergeoncegreen PR is ready to merge after CI passes label Dec 21, 2023
@clearloop
Copy link
Contributor Author

dispatch failed #3614

@clearloop clearloop merged commit 22e28d8 into master Dec 22, 2023
11 checks passed
@clearloop clearloop deleted the cl/sandbox-deps branch December 22, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshep gshep gshep approved these changes

@breathx breathx breathx approved these changes

@ukint-vs ukint-vs ukint-vs approved these changes

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clearloop @gshep @breathx @ukint-vs