Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(workspace): replace static-assertions with const fn expressions #3596

Merged
merged 4 commits into from
Jan 9, 2024
Merged

refactor(workspace): replace static-assertions with const fn expressions #3596

merged 4 commits into from
Jan 9, 2024

Conversation

StackOverflowExcept1on
Copy link
Member

Resolves #3595

@StackOverflowExcept1on StackOverflowExcept1on added the A4-insubstantial Not too important PR label Dec 15, 2023
shamilsan
shamilsan approved these changes Dec 15, 2023
View reviewed changes
@shamilsan
Copy link
Contributor

@StackOverflowExcept1on, need to appease clippy.

@StackOverflowExcept1on
Copy link
Member Author

StackOverflowExcept1on commented Dec 18, 2023 •
edited
Loading

@shamilsan rust-lang/rust-clippy#11966
I'm waiting for the rust repository to sync with clippy

breathx
breathx approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atm whitelist clippy error pls and mark them to be deleted once compiler upgraded

@breathx breathx added the A2-mergeoncegreen PR is ready to merge after CI passes label Jan 8, 2024
@StackOverflowExcept1on
Copy link
Member Author

@breathx I have temporarily disabled false positive clippy lint in CI

@StackOverflowExcept1on StackOverflowExcept1on merged commit 4ad375b into master Jan 9, 2024
@StackOverflowExcept1on StackOverflowExcept1on deleted the av/remove-static-assertions branch January 9, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techraed techraed techraed approved these changes

@shamilsan shamilsan shamilsan approved these changes

@breathx breathx breathx approved these changes

Assignees
No one assigned
Labels
A2-mergeoncegreen PR is ready to merge after CI passes A4-insubstantial Not too important PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace static-assertions with const fn expressions
4 participants
@StackOverflowExcept1on @shamilsan @techraed @breathx