feat: Update substrate to v0.9.43 #3446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukint-vs
force-pushed
the
vs/substrate-v0.9.43-2
branch
from
e1a52ca to
3510f31
Compare
breathx
approved these changes
Oct 29, 2023
| @@ -176,12 +179,6 @@ where | |||
| RuntimeApiCollection<StateBackend = sc_client_api::StateBackendFor<FullBackend, Block>>, | |||
| ExecutorDispatch: NativeExecutionDispatch + 'static, | |||
| { | |||
| if config.keystore_remote.is_some() { | |||
There was a problem hiding this comment.
Does remote keystore now supported? hm
| pub struct NominationPoolsMigrationV4OldPallet; | ||
| impl Get<Perbill> for NominationPoolsMigrationV4OldPallet { | ||
| fn get() -> Perbill { | ||
| Perbill::from_percent(10) |
There was a problem hiding this comment.
| @@ -467,6 +469,36 @@ impl<T: Config> OnUnbalanced<NegativeImbalanceOf<T>> for OffsetPool<T> { | |||
| } | |||
| } | |||
|
|
|||
| // DustRemoval handler | |||
There was a problem hiding this comment.
what was the problem of previous impl? trait bounds? than add todo to remove initial one
There was a problem hiding this comment.
Conflicting implementation. Since balances::DustHandler switched to fungible::Credit from Imbalance. But we are using Imbalance in fn align_supply
There was a problem hiding this comment.
We don't need Todo. Both structs are for two different implementation and purposes
ukint-vs
force-pushed
the
vs/substrate-v0.9.43-2
branch
from
5e65f91 to
5a182a7
Compare
ukint-vs
force-pushed
the
vs/substrate-v0.9.43-2
branch
from
5a182a7 to
2f3ecab
Compare
|
This should go in separate release |
NikVolf
requested changes
Nov 8, 2023
breathx
added
A5-dontmerge
|
Can we finally merge it and make update to 0.43 ASAP? |
|
To be merged into separate release branch, isn't it? @ukint-vs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update substrate to v0.9.42:
set_balance->force_set_balanceOnUnbalancedforOffsetPoolDustin staking-rewardsupdate substrate to v0.9.43:
todo:
@gear-tech/dev