Markdown: Add support for GTK3 #94
Conversation
| bottom_attach, xoptions, yoptions, 0, 0); | ||
| #else | ||
| gtk_grid_attach(table, child, left_attach, top_attach, | ||
| right_attach - left_attach, bottom_attach - top_attach); |
There was a problem hiding this comment.
You don't use the [xy]options at all in the GTK3 code path, is that sensible? I mean, if they really aren't useful, maybe just remove them altogether and keep always the same default in the GTK2 code?
There was a problem hiding this comment.
Yeah, that or to find the GtkGrid equivalent (this is first time I used that widget), since there are a few places in the code where it uses GTK_FILL | GTK_EXPAND rather than just GTK_FILL, for example.
There was a problem hiding this comment.
If you use them you should rather fix the GtkGrid code indeed. The equivalent on GTK3 is per-widget align/expand (you can see https://developer.gnome.org/gtk3/stable/ch28s02.html).
|
Looks a bit pedantic to wrap the GtkTable stuff, but otherwise it looks OK. |
|
GtkTable is deprecated since GTK+ 3.4, so rather than cause a bunch of compiler warnings, I figured providing a compatibility wrapper would be better. |
This PR adds support for GTK3 by adjusting build system as well as adding some GTK2-compatibility code.
TODO: Waf build system support for GTK+3 Markdown plugin.