Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed document list menu position bug #895

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

PatrickGMM
Copy link
Contributor

Fixed document list menu position bug when the tool button has been moved to the toolbar overflow menu

  • tested on builds of Geany 1.35 for Gtk versions 3.22.30 and 2.24.32

…oved

to the toolbar overflow menu
  - tested on builds of Geany 1.35 for Gtk versions 3.22.30 and 2.24.32
Copy link
Member

@eht16 eht16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you describe in a bit more detail the exact problem?
I see the overflow menu appears "somewhere" on the screen but it still works basically. It's just offsetted.

Your changes seems to fix this quite fine, just want to know if there are more problems than the mispositioning.

addons/src/ao_doclist.c Show resolved Hide resolved
addons/src/ao_doclist.c Outdated Show resolved Hide resolved
@PatrickGMM
Copy link
Contributor Author

Could you describe in a bit more detail the exact problem?
I see the overflow menu appears "somewhere" on the screen but it still works basically. It's just offsetted.

Your changes seems to fix this quite fine, just want to know if there are more problems than the mispositioning.

The main problem was the positioning. And the description in the overflow menu was simply "Index" which I changed to "Document List" which is more descriptive of the plugin feature.

@eht16
Copy link
Member

eht16 commented Aug 11, 2019

Ok, thanks for clarifying.
When you changed the remaining points, we can merge it.

I tested only on GTK2.

@eht16 eht16 merged commit 9694c62 into geany:master Aug 13, 2019
@eht16
Copy link
Member

eht16 commented Aug 13, 2019

Thanks.

@PatrickGMM PatrickGMM deleted the addons-doclist-update-overflow-menu branch August 14, 2019 00:56
PatrickGMM added a commit to PatrickGMM/geany-plugins that referenced this pull request Aug 14, 2019
Fixed document list menu position bug (geany#895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants