Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lineoperations: added keybindings. See #832. #889

Merged
merged 1 commit into from
Jul 28, 2019
Merged

lineoperations: added keybindings. See #832. #889

merged 1 commit into from
Jul 28, 2019

Conversation

lpaulsen93
Copy link
Contributor

Added keybindings for all menu items of the Line Operations plugin.

@lpaulsen93
Copy link
Contributor Author

@smostertdev: please have a look if you got the time.

smostertdev
smostertdev approved these changes Jul 28, 2019
View reviewed changes
Copy link
Contributor

@smostertdev smostertdev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks good to me. I compiled it and tested the keybindings for a few menu options, and everything works great. Feel free to add yourself into the AUTHORS file if you'd like. Thanks for making this PR.

@frlan frlan merged commit a0e0ab2 into geany:master Jul 28, 2019
@lpaulsen93 lpaulsen93 mentioned this pull request Jul 28, 2019
Closed
@lpaulsen93 lpaulsen93 deleted the line-ops-keybindings branch August 10, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smostertdev smostertdev smostertdev approved these changes

Assignees
No one assigned
Labels
enhancement plugin/lineoperations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpaulsen93 @smostertdev @frlan