scope: Improved evaluation on-hover

[lpaulsen93]

Scope automatically evaluates an expression if the mouse pointer is hovered over it. But before this change it only evaluated words. E.g. if the mouse was hovered over structa->item1 then scope would have evaluated structa or itemb depending on the exact position of the mouse pointer. With this change it will instead evaluate the value of structa->item1.

[b4n]

Just from the top of my head, wouldn't it be better to evaluate structa when over structa, and structa->item1 when over item1? I think it's reasonably useful to be able to get the evaluation of a part of the expression, here the parent.

Also if you wanted to be thorough, the C and C++ syntax allows for any kind of spaces between structa, -> and item1 😁

[lpaulsen93]

Just from the top of my head, wouldn't it be better to evaluate structa when over structa, and structa->item1 when over item1?

Yes, good idea. I'll try to implement that.

Also if you wanted to be thorough, the C and C++ syntax allows for any kind of spaces between structa, -> and item1 😁

True. But and it might even include linebreaks I think. And for C++ we might need to allow :: for static class members.

[lpaulsen93]

@b4n, @elextr: I just pushed another improvement for the on-hover-evaluation of expressions. It works like suggested by b4n and also allows spaces but it does only work on the current line.

I wanted to write unit tests for the function that parses the current line and extracts the expression to evaluate. But my unit tests don't build. I have setup an extra folder tests. In it are the test files. If I try to build the tests via make check then compilation for the scope unit tests fails because check.h cannot be found. Another thing is that if I remove the comments from scope/tests/Makefile.am then none of the tests source code files is compiled. It now looks like this:

#if UNITTESTS

include $(top_srcdir)/build/vars.build.mk
plugin = scope

check_PROGRAMS = scope-check

scope_check_SOURCES  = unittests.c utils_test.c
scope_check_CPPFLAGS = -DTEST
scope_check_CFLAGS   = $(GEANY_CFLAGS) -DUNITTESTS
scope_check_LDADD    = @GEANY_LIBS@ $(INTLLIBS) @CHECK_LIBS@

TESTS = $(check_PROGRAMS)

#endif

So it seems that I have overseen one magic autotools switch which is still missing. Any help would be highly appreciated.

[lpaulsen93]

So it seems that I have overseen one magic autotools switch which is still missing. Any help would be highly appreciated.

Junk! I simply forgot to install check on my machine (embarrassing). For anyone reading this: make sure you have check installed if you want to write unit tests. Otherwise you might get an error message like this:

If you execute the command ./autogen.sh it will show if check is present/if unit tests can be created:

In case check is installed it will show Unit tests: yes. If not, building tests via make check will fail.

[lpaulsen93]

This looks quite good to me now. Unit tests worked and were run successfully on my machine. Unfortunately scope isn't build in Travis CI as VTE support is missing.

The array in scope/src/tests/utils_test.c shows which situations are handled.

[lpaulsen93]

@frlan: I would also like to have this one in milestone 1.36.0 - if no one objects.

[lpaulsen93]

@b4n, @frlan: If no one objects I will merge this soon also.

[lpaulsen93]

No complaints, so I merge this now.