Addons: Implement deselect with single click #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if it's useful, but Scintilla has a double-click notification. |
|
I used I removed the |
|
I actually found a better way: see a0ef5fd and its message. |
For this to work, we need to connect to the "button-press-event" for each document, then process each single click and delay the detected double click event by 50ms before processing it. This way all markers will be removed (in case of double click actually twice) and new markers will be set on double click. Due to the new behaviour introduced here, the feature is disabled by default. Closes geany#445.
eht16
force-pushed
the
issue445_markall_single_click
branch
from
a0ef5fd to
26e6906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this to work, we need to connect to the "button-press-event" for
each document and then differentiate between single and double
clicks, using a timeout handler which is triggered first after the GTK
double-click-time has passed, i.e. GTK won't recognise the event as part
of a double click.
I didn't find a easier solution to differentiate between single and double click.
Better ideas are welcome.
Closes #445.