Use new spawn API to fix broken Win32 ctags.exe command execution #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the new spawn API, which is used by utils_spawn_sync() as well, passing a whole command line in argv[0] doesn't work any longer. So use the new spawn API directly which conveniently offers to pass the command either as command line or as argv.
|
@eht16 Ah, missed this one. Works fine on linux and I trust you on Windows :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the new spawn API, which is used by utils_spawn_sync() as well,
passing a whole command line in argv[0] doesn't work any longer.
So use the new spawn API directly which conveniently offers to
pass the command either as command line or as argv.
Tested on Linux and Windows.
I bumped the required API version. It seems unfortunately we didn't bump the API version in Geany when merging the spawn API but the currently used 226 is newer than the spawn API and is already available in the last Geany release, so it should be ok.