Set G_LOG_DOMAIN for proper GLib error reporting/logging #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks OK to me, do you mind applying it upstream? |
|
Done in codebrainz/geanypy#40 |
|
Merged upstream in codebrainz/geanypy@d11b4eb |
eht16
referenced
this pull request
in eht16/geanypy
Feb 23, 2016
|
@codebrainz Is this safe to also apply here? |
|
@frlan I haven't tested it against GP but it built fine in the upstream build system. If it builds, it should be fine, otherwise the preprocessor would spew out errors early. |
frlan
added a commit
that referenced
this pull request
Mar 4, 2016
Set G_LOG_DOMAIN for proper GLib error reporting/logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns messages like:
into