Macro plugin compatibility for both gtk2 and gtk3 [Needs Testing] #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1387,21 +1386,26 @@ static void EditSearchOptions(GtkTreeModel *model,GtkTreeIter *iter) | |||
| /* create dialog box */ | |||
| dialog=gtk_dialog_new_with_buttons(_("Search Options:"), | |||
| GTK_WINDOW(geany->main_widgets->window), | |||
| GTK_DIALOG_DESTROY_WITH_PARENT,NULL); | |||
| GTK_DIALOG_DESTROY_WITH_PARENT, | |||
| _("Ok"), | |||
There was a problem hiding this comment.
Mnemonic should not be removed (unless actually wanted)
|
Indentation has some problems, and some code should be dropped rather than commented out. Also, did you check how the widgets expand? |
|
@b4n I guess I did unnecessary changes regarding |
|
Hum, according to GitHub there are no changes. And apparently the version in master already supports GTK3 just fine, because of #410 |
added 6 commits
June 20, 2016 09:58
|
This has already been implemented by #410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on a patch. It builds on gtk3 as well as gtk2 but not thoroughly tested.