-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geanypy: Update bundled ax_python_devel.m4 to latest upstream #339
geanypy: Update bundled ax_python_devel.m4 to latest upstream #339
Conversation
This actually fixes building on Debian Unstable that ships ax_python_devel.m4 in autoconf-archive, and apparently aclocal prefers system directories. So we get the system version, which happens to be the latest, which changed API. To avoid breaking older systems that would also ship ax_python_devel.m4 but in an older version with the older API, keep using the old API too.
This however raises a more important concern: if the API changes again having the macro bundled doesn't help at least on Debian if the system has it too. I didn't yet investigate this part of the issue, but it might be something to worry about as apparently they sometimes change API. BTW, although the incompatible change itself makes sense, maybe it'd be worth reporting the annoyance upstream? or to Debian? @sardemff7 opinion? knowledge on the issue? |
Also, maybe I we should rename ax_python_library.m4 as it effectively is a custom thing. Or submit it upstream, maybe. |
As I see it, the A few comments:
|
It currently doesn't, I was just referring to possible future occurrences of a similar issue.
Well. There's 2 problems here
Oh, so it looks at the serial? I learned something :)
Hum, maybe. In Debian there's also a pkg-config file for python2.7. Though, I don't think either one have the same information as the ones fetched by |
geanypy is pretty much python2-only at the moment (as well as gtk2-only). I don't think any of the people involved is planning on changing that. So the short term fix is to ensure python2 is enforced for autotools. |
…oconf-archive geanypy: Update bundled ax_python_devel.m4 to latest upstream
This actually fixes building on Debian Unstable that ships
ax_python_devel.m4 in autoconf-archive, and apparently aclocal prefers
system directories. So we get the system version, which happens to be
the latest, which changed API.
To avoid breaking older systems that would also ship ax_python_devel.m4
but in an older version with the older API, keep using the old API too.