Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported treebrowser plugin to GTK+ >= 3.10.0 #278

Closed
wants to merge 7 commits into from
Closed

Ported treebrowser plugin to GTK+ >= 3.10.0 #278

wants to merge 7 commits into from

Conversation

paolostivanin
Copy link

now the treebrowser plugin uses GTK+ API compatible with version 3.10.0 and above. No more warnings during compilation :)

Tested on Arch x64, Ubuntu 14.04 x86, Ubuntu 15.04 amd64.

@b4n
Copy link
Member

b4n commented Aug 29, 2015

I don't like this. It adds a GTK 3.16 dependency for no good reason IMO.
Also, dropping all icons is questionable, but well, that's another topic.

@b4n
Copy link
Member

b4n commented Aug 29, 2015

At the very least the changes on the various plugins should be separate PRs.

@paolostivanin
Copy link
Author

I didn't add GTK+ 3.16 functions :) I also think is not a good idea to use that version because *buntu 14.04 LTS users wouldn't be able to use Geany GTK+3 ;)

@paolostivanin
Copy link
Author

Ok. So, can I close this pull request and open 3 new ones?

@b4n
Copy link
Member

b4n commented Aug 29, 2015

I didn't add GTK+ 3.16 functions :)

You use GtkLabel::xalign which was introduced by 3.16. Of course, you set it dynamically so it's not that bad, but it's kinda bad to set an non-existing property.

Ok. So, can I close this pull request and open 3 new ones?

Yes, but I myself won't merge them. As those are plugins not part of Geany core I won't oppose to them, but you'll need to convince someone else.

@paolostivanin
Copy link
Author

I've already remove that code, it was my mistake :) I'll push it with the new prs I'm gonna create!
BTW, thanks for your time @b4n !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants