-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ported treebrowser plugin to GTK+ >= 3.10.0 #278
Conversation
I don't like this. It adds a GTK 3.16 dependency for no good reason IMO. |
At the very least the changes on the various plugins should be separate PRs. |
I didn't add GTK+ 3.16 functions :) I also think is not a good idea to use that version because *buntu 14.04 LTS users wouldn't be able to use Geany GTK+3 ;) |
Ok. So, can I close this pull request and open 3 new ones? |
You use
Yes, but I myself won't merge them. As those are plugins not part of Geany core I won't oppose to them, but you'll need to convince someone else. |
I've already remove that code, it was my mistake :) I'll push it with the new prs I'm gonna create! |
now the treebrowser plugin uses GTK+ API compatible with version 3.10.0 and above. No more warnings during compilation :)
Tested on Arch x64, Ubuntu 14.04 x86, Ubuntu 15.04 amd64.