GeanyPy: Unload Python plugins when GeanyPy is deactivated #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents crashes and/or lockups when the GeanyPy C plugin is reloaded. FIXME: Because it calls the normal unloading path, it updates the list of loaded plugins to remove each plugin. The net effect is that when the C GeanyPy plugin is unloaded, it forgets all of the Python plugins that were loaded at the time.
|
Feel free to leave out of release, but it might save some bug reports. |
|
This seem to mostly work (no more crashes after manually unloading the plugin), although it's super annoying as this means on every geany run (well, whenever it quits, which unloads the plugin) all Python plugins need to be re-enabled. |
|
Postponed to post 1.25 due to the massiv effect on restart of Geany. |
|
Related: codebrainz/geanypy#31 |
|
@kugel- As you are currently maintainer of this part of geanypy, can you please have a look whether it's still a point? |
|
Geanypy is a proxy plugin these days. These cannot be deactivated (through the GUI) without deactivating each and every subplugin. This can be closed, thanks for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents crashes and/or lockups when the GeanyPy C plugin
is reloaded.
FIXME: Because it calls the normal unloading path, it updates
the list of loaded plugins to remove each plugin. The net effect
is that when the C GeanyPy plugin is unloaded, it forgets all
of the Python plugins that were loaded at the time.