Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotools: Add a flag to enable or disable all plugins #236

Merged
merged 2 commits into from
Jul 4, 2015

Conversation

b4n
Copy link
Member

@b4n b4n commented Jun 6, 2015

This allows to change the default for whether every plugins are enabled or disabled, effectively allowing to easily select either all, or only a specific set of plugins.

To force enable all plugins:
configure --enable-all-plugins

To force enable all plugins, but disable Addons:
configure --enable-all-plugins --disable-addons

To force enable all plugins, but Addons which is checked automatically:
configure --enable-all-plugins --enable-addons=auto

To disable all plugins, but force enable Addons:
configure --disable-all-plugins --enable-addons

This allows to change the default for whether every plugins are enabled
or disabled, effectively allowing to easily select either all, or only
a specific set of plugins.

To force enable all plugins:
	configure --enable-all-plugins

To force enable all plugins, but disable Addons:
	configure --enable-all-plugins --disable-addons

To force enable all plugins, but Addons which is checked automatically:
	configure --enable-all-plugins --enable-addons=auto

To disable all plugins, but force enable Addons:
	configure --disable-all-plugins --enable-addons
@codebrainz
Copy link
Member

It's not clear (to me) from the M4 whether --enable-all-plugins=auto is accepted or the default (you mention "force" so it sounds like not). It might be useful and seems to be supported in the _GP_ARG_DISABLE_ALL part.

Other than that, I think this is a really good idea.

@codebrainz
Copy link
Member

I think someone said this is already supported by Waf build system, but it might be useful to add all as a plugin name that can be used with --list-plugins, --enable-plugins, and --skip-plugins to make it explicit?

@b4n
Copy link
Member Author

b4n commented Jun 7, 2015

It's not clear (to me) from the M4 whether --enable-all-plugins=auto is accepted or the default (you mention "force" so it sounds like not). It might be useful and seems to be supported in the _GP_ARG_DISABLE_ALL part.

You can pass auto and it's the default, which doesn't change the current behavior. Passing auto however is pretty much useless as it has virtually no effect.

@frlan
Copy link
Member

frlan commented Jun 25, 2015

Shall we put this into 1.25?

@frlan frlan added this to the 1.25 milestone Jun 25, 2015
@b4n
Copy link
Member Author

b4n commented Jun 25, 2015

@frlan I think we should, but I wished for some comments here from the people complaining about the missing feature. Without them, I can't really know if they appreciate this solution, or if they would rather have some other interface.

@zhekov do you have an opinion on this?

@b4n
Copy link
Member Author

b4n commented Jun 27, 2015

Added some docs

@b4n b4n force-pushed the autotools/global-enable-switch branch from 1b82b04 to 4f2f2bd Compare June 27, 2015 14:00
@b4n b4n force-pushed the autotools/global-enable-switch branch from 4f2f2bd to fed3478 Compare June 30, 2015 20:00
@b4n b4n merged commit fed3478 into geany:master Jul 4, 2015
b4n added a commit that referenced this pull request Jul 4, 2015
Add a flag to the Autotools build system to enable or disable all
plugins at once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants