Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overview: Support Cairo < 1.12 #227

Closed
wants to merge 1 commit into from
Closed

Conversation

b4n
Copy link
Member

@b4n b4n commented May 4, 2015

Closes #222.

@codebrainz
Copy link
Member

I need to add a note to the README file (I only mentioned it in initial PR description), but ideally PRs/changes could be made against my upstream repo as it uses it's own build system so it can be free-standing as well, and there's a script to update the fork in Geany-Plugins. In any case, go ahead and merge if you want, since it's breaking the nightly build, and there's already been changes on the fork I'll have to port back to upstream.

IMO, it'd be nicer to not redefine the meaning of that constant though, and rather just guard out the single call to set anti-aliasing mode, but it's no big deal, and I can easily change it later.

@b4n
Copy link
Member Author

b4n commented May 5, 2015

If you fix it soon-ish I really don't mind, and you can do it the way you prefer it.

And indeed if the call is not strictly required it's probably nicer to just not perform it than redefine GOOD.

@codebrainz
Copy link
Member

I should really check, because the _DEFAULT constant name might be misleading and AA might be off by default or something. Also, thanks for the patches upstream!

codebrainz added a commit that referenced this pull request May 7, 2015
* Add guard to not depend on too new Cairo version
* Add guard to allow building with older Geany versions

Closes #222 #227
@codebrainz
Copy link
Member

Closed in 1f08a36

@codebrainz codebrainz closed this May 7, 2015
marcelogp pushed a commit to marcelogp/geany-plugins that referenced this pull request Oct 26, 2015
* Add guard to not depend on too new Cairo version
* Add guard to allow building with older Geany versions

Closes geany#222 geany#227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overview: Not compiling against cairo 1.10 (e.g. on Windows)
2 participants