geanylua: Update to match latest Geany's Scintilla API #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest Scintilla interface file has a few trailing spaces which confuses the mkiface script. So, fix it to ignore those.
This adds new methods, and fixes build removing 2 deprecated (and then missing) ones.
frlan
added a commit
that referenced
this pull request
Apr 23, 2015
geanylua: Update to match latest Geany's Scintilla API
|
BTW if we want to keep the deprecated Scintilla symbols to avoid possibly breaking some user scripts (if anyone actually uses that), it'd be relatively easy to do. Not sure if we want though, last time there was a deprecated symbol we just dropped it IIRC. |
|
I would drop the deprecated things until somebody wants to actively maintain the plugin and supporting such a thing. |
|
okay, sounds fair to me |
sagarchalise
pushed a commit
to sagarchalise/geany-plugins
that referenced
this pull request
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new methods, and fixes build removing 2 deprecated (and then missing) ones.
Closes #217