Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger: Safer GDB/MI parsing and other fixes #202

Merged
merged 20 commits into from
Nov 15, 2015
Merged

debugger: Safer GDB/MI parsing and other fixes #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
53e9141
debugger: Mark some arguments const
b4n Oct 24, 2014
697fc79
debugger: Fix a few GError leaks
b4n Oct 24, 2014
5ddb7c7
debugger: Add a real GDB/MI parser
b4n Oct 25, 2014
2b38b72
debugger: Avoid a theoretically possible buffer overflow
b4n Oct 25, 2014
785b835
debugger: Avoid undefined behavior with strcpy()
b4n Oct 25, 2014
ecb4ba7
debugger: Don't work on NULL GString or GHashTable
b4n Oct 25, 2014
c40d334
debugger: Don't remove non-existent GSources
b4n Oct 25, 2014
dc7804b
debugger: Avoid possible overflows with strcpy()
b4n Oct 25, 2014
0a61a76
debugger: Don't try destroying a NULL GHashTable
b4n Oct 25, 2014
b7b4677
debugger: Consolidate code for selecting the target file
b4n Oct 25, 2014
ca63317
debugger: Fix a few things in the GDB/MI parser
b4n Oct 25, 2014
3afcc8f
debugger: Make GCC happy
b4n Oct 25, 2014
eed4e13
debugger: Use the GDB/MI module to parse GDB output in the GDB module
b4n Oct 25, 2014
f0b2d4b
debugger: Fix a few integer signedness comparison issues
b4n Oct 27, 2014
d628a10
debugger: Fix a few memory leaks
b4n Oct 27, 2014
c823ecc
debugger: Restore behavior when GDB stops with reason=location-reached
b4n Oct 27, 2014
5e52d09
debugger: Fix several potential buffer overflows
b4n Mar 7, 2015
b8ba6f9
debugger/gdb_mi: Fix prompt detection
b4n Mar 8, 2015
f0eb05c
debugger/gdb_mi: Fix possible out-of-bounds read
b4n Mar 8, 2015
65a4e65
debugger/gdb_mi: Add a few tests
b4n Mar 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions debugger/src/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ debugger_la_SOURCES = \
envtree.h \
gui.h \
gui.c \
gdb_mi.h \
gdb_mi.c \
keys.c \
keys.h \
atree.c \
Expand Down Expand Up @@ -72,4 +74,14 @@ debugger_la_SOURCES = \
debugger_la_LIBADD = $(COMMONLIBS) $(VTE_LIBS) -lutil
debugger_la_CFLAGS = $(AM_CFLAGS) $(VTE_CFLAGS) -DDBGPLUG_DATA_DIR=\"$(plugindatadir)\" -DPLUGIN_NAME=\"$(plugin)\"

check_PROGRAMS = gdb_mi_test
dist_check_SCRIPTS = tests/gdb_mi_test.sh
dist_check_DATA = tests/gdb_mi_test.input tests/gdb_mi_test.expected
TESTS = $(dist_check_SCRIPTS)

gdb_mi_test_SOURCES = gdb_mi.c gdb_mi.h
gdb_mi_test_CFLAGS = $(AM_CFLAGS) -DTEST
gdb_mi_test_LDFLAGS =
gdb_mi_test_LDADD = $(COMMONLIBS)

include $(top_srcdir)/build/cppcheck.mk
4 changes: 2 additions & 2 deletions debugger/src/breakpoint.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ breakpoint* break_new(void)
breakpoint* break_new_full(const char* file, int line, const char* condition, int enabled, int hitscount)
{
breakpoint* bp = break_new();
strcpy(bp->file, file);
strncpy(bp->file, file, G_N_ELEMENTS(bp->file) - 1);
bp->line = line;
if (condition)
strcpy(bp->condition, condition);
strncpy(bp->condition, condition, G_N_ELEMENTS(bp->condition) - 1);
bp->enabled = enabled;
bp->hitscount = hitscount;

Expand Down
4 changes: 2 additions & 2 deletions debugger/src/breakpoints.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ static void breaks_set_condition_debug(breakpoint* bp)
{
/* revert to old condition (taken from tree) */
gchar* oldcondition = bptree_get_condition(bp);
strcpy(bp->condition, oldcondition);
strncpy(bp->condition, oldcondition, G_N_ELEMENTS(bp->condition) - 1);
g_free(oldcondition);
/* show error message */
dialogs_show_msgbox(GTK_MESSAGE_ERROR, "%s", debug_error_message());
Expand Down Expand Up @@ -596,7 +596,7 @@ void breaks_set_condition(const char* file, int line, const char* condition)
return;

/* change condition */
strcpy(bp->condition, condition);
strncpy(bp->condition, condition, G_N_ELEMENTS(bp->condition) - 1);

/* handle setting condition instantly if debugger is idle or stopped
and request debug module interruption overwise */
Expand Down
Loading