Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geanylua: Do not accept Lua5.2 as the plugin doesn't build with it #188

Merged
merged 1 commit into from
Feb 16, 2015

Conversation

b4n
Copy link
Member

@b4n b4n commented Feb 12, 2015

Make sure the found Lua package is version 5.1 and not newer, as 5.2
breaks compilation.

The issue with 5.2 was reported by an user on IRC.

@frlan
Copy link
Member

frlan commented Feb 12, 2015

Can you add also something to wscript?

Make sure the found Lua package is version 5.1 and not newer, as 5.2
breaks compilation.

The issue with 5.2 was reported by an user on IRC.
@b4n
Copy link
Member Author

b4n commented Feb 12, 2015

@frlan food remark, fixed. It works but it might be quite ugly as I don't know much about Waf (e.g. I didn't find a better way to check for < 5.2, but admittedly I couldn't find the canonical docs for conf.check_cfg()).

@eht16
Copy link
Member

eht16 commented Feb 12, 2015

pkg-config also knows --max-version but for lua-5.1 we probably would need to set --max-version 5.1.99 or something. So I actually think your current version constraint isn't that ugly.

@b4n
Copy link
Member Author

b4n commented Feb 12, 2015

@eht16 yeah I found out about max_version but as you say it's a <= check, so not what we need here.
And ok, if you can't tell me there's a better way to do it there mustn't be any I guess :)

@eht16
Copy link
Member

eht16 commented Feb 13, 2015

Yes, I don't know a better solution. Though I don't agree that this is the same as there is no better solution :).

Let's merge it.

frlan added a commit that referenced this pull request Feb 16, 2015
geanylua: Do not accept Lua5.2 as the plugin doesn't build with it
@frlan frlan merged commit 8b15f7a into geany:master Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants