Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tm #165

Merged
merged 3 commits into from
Nov 8, 2014
Merged

Tm #165

merged 3 commits into from
Nov 8, 2014

Conversation

techee
Copy link
Member

@techee techee commented Oct 18, 2014

This are the changes made to the plugins to reflect the changes made to the tag manager in Geany, see

geany/geany#356

The affected plugins are gproject, geanyprj and geanygendoc.

The first patch replaces TmWorkObject with TmSourceFile and also uses the bulk tm_workspace_update() instead of individual file updates.

The second patch is just mechanical removal of "atts.entry." to reflect the simplification of TMTag.

This should't be applied until the TM changes are merged into Geany.

@techee techee mentioned this pull request Oct 18, 2014
b4n referenced this pull request in techee/geany Oct 21, 2014
The only real change is the removal of struct and union in TMTag, the
rest is purely mechanical removal of "atts.entry." everywhere.
@techee
Copy link
Member Author

techee commented Nov 2, 2014

The patch towards the latest TM API looks a bit bigger/uglier for several reasons:

  1. I didn't play much with the gproject code - I have another branch with new feature additions where I did it properly and in a simpler way and the code in this patch is just in order to compile the plugins and have something working.
  2. geanyprj: the code is a bit hard to get oriented in. I don't like the _steel part of the code I have introduced but without it I'd have to rewrite much bigger part of the code. I have also fixed some problems from the previous commit I made and while trying to understand the code, removed the code which wasn't necessary and was misleading. It seems to work but I'll try to ping Yura if he has time to review it and if he's fine with the changes.

@techee
Copy link
Member Author

techee commented Nov 5, 2014

Geanyprj actually used the update function but first I don't think the TM related code does things completely right, second it does it on file save only so the performance isn't critical - I just call remove() and add() to force update.

techee added a commit that referenced this pull request Nov 8, 2014
@techee techee merged commit 28edfa8 into geany:master Nov 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant