Autoclose: fix bug with return between sci_undo* #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return between sci_undo transaction will break undos completely
| @@ -410,7 +410,7 @@ | |||
| if (char_is_curly_bracket(ch)) | |||
| { | |||
| if (line_start == line_end) | |||
| return AC_CONTINUE_ACTION; | |||
| goto final; | |||
There was a problem hiding this comment.
Not sure sure whether it's a good idea here to use goto.
frlan
added a commit
that referenced
this pull request
Nov 4, 2013
Autoclose: fix bug with return between sci_undo*
sblatnick
pushed a commit
to sblatnick/geany-plugins
that referenced
this pull request
Nov 12, 2013
Treeviewer: Open new created file. Should close Feature request geany#123
b4n
added a commit
to b4n/geany
that referenced
this pull request
Feb 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return between sci_undo transaction will break undos completely