Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpellCheck: Sync toggle via keybinding and button #1161

Merged
merged 3 commits into from
Apr 3, 2022
Merged

SpellCheck: Sync toggle via keybinding and button #1161

merged 3 commits into from
Apr 3, 2022

Conversation

eht16
Copy link
Member

@eht16 eht16 commented Jan 29, 2022

Fixes #1158.

@eht16 eht16 mentioned this pull request Feb 9, 2022
Closed
@eht16 eht16 force-pushed the issue1158_sync_toggle_via_keybinding_and_button branch from 27d2bf7 to a475386 Compare February 13, 2022 16:48
@eht16
Copy link
Member Author

eht16 commented Feb 20, 2022

I'd like to merge this in a few days if there is no other feedback (the discussion in the related issue seems finished).

@ralf3u
Copy link

ralf3u commented Apr 1, 2022

@eht16

I'd like to merge this in a few days [...]

I just wanted to ask why this issue is still not closed (same for #1158)?
Thank you for an answer in advance.

@eht16 eht16 merged commit aaac91d into geany:master Apr 3, 2022
@eht16
Copy link
Member Author

eht16 commented Apr 3, 2022

I just wanted to ask why this issue is still not closed (same for #1158)? Thank you for an answer in advance.

Because real-life happened :).
Sorry, didn't had much time in the last weeks. But finally merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin/spellcheck
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spell Check: toggle with just one shortcut
2 participants
@eht16 @ralf3u