Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projectorganizer: Restore tree state in the sidebar #1144

Merged
merged 3 commits into from
May 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion projectorganizer/src/prjorg-main.c
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,10 @@ static void on_project_open(G_GNUC_UNUSED GObject * obj, GKeyFile * config,
{
if (!prj_org)
{
gchar **arr = prjorg_project_load_expanded_paths(config);

prjorg_project_open(config);
prjorg_sidebar_update(TRUE);
prjorg_sidebar_update_full(TRUE, arr);
prjorg_sidebar_activate(TRUE);
prjorg_menu_activate_menu_items(TRUE);
}
Expand Down
19 changes: 19 additions & 0 deletions projectorganizer/src/prjorg-project.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

#include "prjorg-utils.h"
#include "prjorg-project.h"
#include "prjorg-sidebar.h"

extern GeanyPlugin *geany_plugin;
extern GeanyData *geany_data;
Expand Down Expand Up @@ -377,6 +378,16 @@ static void update_project(
}


static void save_expanded_paths(GKeyFile * key_file)
{
gchar **expanded_paths = prjorg_sidebar_get_expanded_paths();

g_key_file_set_string_list(key_file, "prjorg", "expanded_paths",
(const gchar**) expanded_paths, g_strv_length(expanded_paths));
g_strfreev(expanded_paths);
}


void prjorg_project_save(GKeyFile * key_file)
{
GPtrArray *array;
Expand All @@ -385,6 +396,8 @@ void prjorg_project_save(GKeyFile * key_file)
if (!prj_org)
return;

save_expanded_paths(key_file);

g_key_file_set_string_list(key_file, "prjorg", "source_patterns",
(const gchar**) prj_org->source_patterns, g_strv_length(prj_org->source_patterns));
g_key_file_set_string_list(key_file, "prjorg", "header_patterns",
Expand Down Expand Up @@ -478,6 +491,12 @@ void prjorg_project_remove_external_dir(const gchar *utf8_dirname)
}


gchar **prjorg_project_load_expanded_paths(GKeyFile * key_file)
{
return g_key_file_get_string_list(key_file, "prjorg", "expanded_paths", NULL, NULL);
}


void prjorg_project_open(GKeyFile * key_file)
{
gchar **source_patterns, **header_patterns, **ignored_dirs_patterns, **ignored_file_patterns, **external_dirs, **dir_ptr, *last_name;
Expand Down
1 change: 1 addition & 0 deletions projectorganizer/src/prjorg-project.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ typedef struct
extern PrjOrg *prj_org;

void prjorg_project_open(GKeyFile * key_file);
gchar **prjorg_project_load_expanded_paths(GKeyFile * key_file);

GtkWidget *prjorg_project_add_properties_tab(GtkWidget *notebook);

Expand Down
56 changes: 44 additions & 12 deletions projectorganizer/src/prjorg-sidebar.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ typedef enum
typedef struct
{
GeanyProject *project;
GPtrArray *expanded_paths;
gchar **expanded_paths;
gchar *selected_path;
} ExpandData;


Expand Down Expand Up @@ -1487,24 +1488,30 @@ static gboolean expand_path(gchar *utf8_expanded_path, gboolean select)
static gboolean expand_on_idle(ExpandData *expand_data)
{
GeanyDocument *doc = document_get_current();
gboolean selected = FALSE;

if (!prj_org)
return FALSE;

if (geany_data->app->project == expand_data->project &&
expand_data->expanded_paths)
{
gchar *item;
guint i;
gchar **item;
foreach_strv(item, expand_data->expanded_paths)
expand_path(*item, FALSE);
g_strfreev(expand_data->expanded_paths);
}

foreach_ptr_array(item, i, expand_data->expanded_paths)
expand_path(item, FALSE);
g_ptr_array_free(expand_data->expanded_paths, TRUE);
if (expand_data->selected_path)
{
expand_path(expand_data->selected_path, TRUE);
g_free(expand_data->selected_path);
selected = TRUE;
}

g_free(expand_data);

if (!s_follow_editor || !doc || !doc->file_name)
if (selected || !s_follow_editor || !doc || !doc->file_name)
return FALSE;

expand_path(doc->file_name, TRUE);
Expand Down Expand Up @@ -1547,26 +1554,45 @@ static void on_map_expanded(GtkTreeView *tree_view, GtkTreePath *tree_path, GPtr
}


static GPtrArray *get_expanded_paths(void)
gchar **prjorg_sidebar_get_expanded_paths(void)
{
GPtrArray *expanded_paths = g_ptr_array_new_with_free_func(g_free);
GPtrArray *expanded_paths = g_ptr_array_new();

gtk_tree_view_map_expanded_rows(GTK_TREE_VIEW(s_file_view),
(GtkTreeViewMappingFunc)on_map_expanded, expanded_paths);
g_ptr_array_add(expanded_paths, NULL);

return expanded_paths;
return g_ptr_array_free(expanded_paths, FALSE);
}


void prjorg_sidebar_update(gboolean reload)
static gchar *get_selected_path(void)
{
GtkTreeSelection *treesel;
GtkTreeIter iter;
GtkTreeModel *model;

treesel = gtk_tree_view_get_selection(GTK_TREE_VIEW(s_file_view));
if (gtk_tree_selection_get_selected(treesel, &model, &iter))
return build_path(&iter);
return NULL;
}


void prjorg_sidebar_update_full(gboolean reload, gchar **expanded_paths)
{
ExpandData *expand_data = g_new0(ExpandData, 1);

expand_data->project = geany_data->app->project;

if (reload)
{
expand_data->expanded_paths = get_expanded_paths();
GtkTreeSelection *treesel;
GtkTreeIter iter;
GtkTreeModel *model;

expand_data->expanded_paths = expanded_paths != NULL ? expanded_paths : prjorg_sidebar_get_expanded_paths();
expand_data->selected_path = get_selected_path();

load_project();
/* we get color information only after the sidebar is realized -
Expand All @@ -1580,6 +1606,12 @@ void prjorg_sidebar_update(gboolean reload)
}


void prjorg_sidebar_update(gboolean reload)
{
prjorg_sidebar_update_full(reload, NULL);
}


void prjorg_sidebar_find_file_in_active(void)
{
find_file(NULL);
Expand Down
3 changes: 3 additions & 0 deletions projectorganizer/src/prjorg-sidebar.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,12 @@ void prjorg_sidebar_find_file_in_active(void);
void prjorg_sidebar_find_tag_in_active(void);

void prjorg_sidebar_update(gboolean reload);
void prjorg_sidebar_update_full(gboolean reload, gchar **expanded_paths);

void prjorg_sidebar_focus_project_tab(void);

gchar **prjorg_sidebar_get_expanded_paths(void);

void on_open_file_manager(G_GNUC_UNUSED GtkMenuItem * menuitem, G_GNUC_UNUSED gpointer user_data);
void on_open_terminal(G_GNUC_UNUSED GtkMenuItem * menuitem, G_GNUC_UNUSED gpointer user_data);

Expand Down