GeanyVC:(Git) Fallback to git rev-parse for getting the repo/worktree's top directory
#1028
Conversation
|
For some reason this fix did not make it into the 1.38. Is there any more details needed for this? |
To be clear, I don't use geanyvc, so I won't spend time understanding enough of the plugin code to be able to review the change, similarly setting up a sacrificial git repo to test it. Especially when related to git workflows and stuff. Although it would be preferable that some other user (like the OP of #285) tests it, in the end if it sits too long and nobody does then IMHO if the plugin maintainer says so (and the build passes) it should be merged. Can you trigger the new CI by pushing an inconsequential change, after all its a year since it was tested, I'm sure there is a comment that needs improving/adding :-) |
…ee's top directory An example setup for worktree: ``` mkdir r1 cd r1 git init git config user.name testuser git config user.email testuser@ echo "f1" >> f1 git add f1 git commit -a -m "added f1" git worktree add ../w1 -b work1 echo "f1:r1" >> f1 git status cd ../w1 git status echo "f2" >> f2 git add f2 git commit -a -m "added f2" echo "f1:w1" >> f1 git status ``` All VC actions should be available for all files in each worktree.
nomadbyte
force-pushed
the
geanyvc/285-git-worktree
branch
from
9fb5de0 to
187dfc2
Compare
|
Here it is -- the commit comment now has the use-case in it too, the code is also now up-to-date with current master. @elextr Do you favor a VCS other than Git? Which one? |
|
I use git but not geanyvc (since I mostly do C/C++ and that not in Geany). Ok, build passed, so safe(ish) to merge, since the CI builds all plugins, if one of them fails the whole build fails and so subsequent PRs all show as failing even if they are for a plugin other than the one that failed (see recent problems with Geanylua failing other plugins). |
Fixes #285.