-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy-to-default-graph-generalization #918
Conversation
d474331
to
e888b01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Left two questions to understand a bit of the context.
@@ -501,7 +500,7 @@ def build_manifest_driver( | |||
zipfile_path: Path | |||
) -> None: | |||
|
|||
with tempfile.TemporaryDirectory() as outdir: | |||
with TemporaryDirectory() as outdir: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it the case that builder.model_graphs
and builder.data_graphs
depend on having created the archive?
At face value it looks like it's never explicitly used, but I assume there's a reason why it needs to be created, even if temporarily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm currently only collecting those graph names as debugging output. I am imagining that we could extend that in the future to report and error if the URLs were missing from the manifest's footprint:
See #912