Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gdsfactory to latest version 7.23 #370

Merged
merged 4 commits into from
Apr 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ classifiers = [
"Operating System :: OS Independent"
]
dependencies = [
"gdsfactory==7.22.2",
"gplugins[tidy3d,sax,schematic]>=0.11,<0.12"
"gdsfactory==7.23.0",
"gplugins[tidy3d,sax,schematic]>=0.12,<0.13"
]
description = "ubcpdk pdk"
keywords = ["python"]
Expand Down
Binary file added tests/ref/_ebeam_BondPad.gds
Binary file not shown.
Binary file added tests/ref/_ebeam_adiabatic_te1550.gds
Binary file not shown.
Binary file added tests/ref/_ebeam_adiabatic_tm1550.gds
Binary file not shown.
Binary file added tests/ref/_ebeam_bdc_te1550.gds
Binary file not shown.
Binary file added tests/ref/_ebeam_bdc_tm1550.gds
Binary file not shown.
Binary file added tests/ref/_ebeam_crossing4.gds
Binary file not shown.
Binary file not shown.
Binary file added tests/ref/_ebeam_splitter_swg_assist_te1310.gds
Binary file not shown.
Binary file added tests/ref/_ebeam_splitter_swg_assist_te1550.gds
Binary file not shown.
Binary file added tests/ref/_ebeam_swg_edgecoupler.gds
Binary file not shown.
Binary file added tests/ref/_ebeam_terminator_te1310.gds
Binary file not shown.
Binary file added tests/ref/_ebeam_terminator_te1550.gds
Binary file not shown.
Binary file added tests/ref/_ebeam_terminator_tm1550.gds
Binary file not shown.
Binary file added tests/ref/_ebeam_y_1550.gds
Binary file not shown.
Binary file added tests/ref/_ebeam_y_adiabatic.gds
Binary file not shown.
Binary file added tests/ref/_ebeam_y_adiabatic_1310.gds
Binary file not shown.
Binary file added tests/ref/_metal_via_15.gds
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file added tests/ref/_thermal_phase_shifter_multimode_500um.gds
Binary file not shown.
Binary file added tests/ref/_thermal_phase_shifter_te_1310_500um.gds
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/ref/add_fiber_array_add_fiber_array_add_fiber_array.gds
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/ref/add_fiber_array_pads_rf.gds
Binary file not shown.
Binary file not shown.
Binary file added tests/ref/cavity_dbr_cavity_2afc46e9.gds
Binary file not shown.
Binary file added tests/ref/coupler_coupler__ubcpdkpcomponents.gds
Binary file not shown.
Binary file not shown.
Binary file modified tests/ref/ebeam_crossing4_2ports.gds
Binary file not shown.
Binary file modified tests/ref/ebeam_y_adiabatic_tapers.gds
Binary file not shown.
Binary file modified tests/ref/gc_te1310.gds
Binary file not shown.
Binary file modified tests/ref/gc_te1310_8deg.gds
Binary file not shown.
Binary file modified tests/ref/gc_te1310_broadband.gds
Binary file not shown.
Binary file modified tests/ref/gc_te1550.gds
Binary file not shown.
Binary file modified tests/ref/gc_te1550_90nmSlab.gds
Binary file not shown.
Binary file modified tests/ref/gc_te1550_broadband.gds
Binary file not shown.
Binary file modified tests/ref/gc_tm1550.gds
Binary file not shown.
Binary file added tests/ref/mmi1x2_mmi1x2__ubcpdkpcomponents.gds
Binary file not shown.
Binary file modified tests/ref/mzi_mzi_a1fe9d55.gds
Binary file not shown.
Binary file modified tests/ref/ring_double_ring_double_a459ac5d.gds
Binary file not shown.
Binary file modified tests/ref/ring_single_dut_ring_single_dut_26538df6.gds
Binary file not shown.
Binary file modified tests/ref/ring_single_ring_single_382b19ee.gds
Binary file not shown.
Binary file not shown.
Binary file added tests/ref/straight_straight__ubcpdkpcomponents.gds
Binary file not shown.
4 changes: 4 additions & 0 deletions tests/test_components.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@
"add_pads",
"add_pins_bbox_siepic_remove_layers",
"import_gds",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (testing): Please add a test case for import_gc.

The modifications to import_gc suggest new functionality has been added. Testing this directly would help ensure its reliability and correctness.

Suggested change
"import_gds",
"import_gds",
"import_gc",
"mzi",
}
# Assuming `import_gc` is the new functionality to be tested
if "import_gc" in cell_names:
test_import_gc() # This is a placeholder for the actual test function for import_gc
cell_names = set(cells.keys()) - set(skip_test)

"import_gc",
"mzi",
"ebeam_adiabatic_tm1550",
"ebeam_swg_edgecoupler",
"ebeam_BondPad",
}
cell_names = set(cells.keys()) - set(skip_test)
dirpath_ref = pathlib.Path(__file__).absolute().parent / "ref"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ info:
route_info_xs_sc_length: 1.0
width: 0.5
module: ubcpdk.components
name: add_fiber_array_add_fiber_array
name: add_fiber_array_add_fiber_array__ubcpdkpcomponents
settings:
component:
function: straight
Expand Down
118 changes: 113 additions & 5 deletions tests/test_components/test_pdk_settings_add_fiber_array_pads_rf_.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,116 @@
function: add_fiber_array_pads_rf
function: add_fiber_array
info: {}
module: ubcpdk.components
name: add_fiber_array_pads_rf
name: add_fiber_array_add_fiber_array_35c727a6
settings:
component: ring_single_heater
orientation: 0
username: JoaquinMatres
component:
function: add_electrical_pads_top
module: gdsfactory.routing.add_electrical_pads_top
settings:
component:
function: ring_single_heater
module: gdsfactory.components.ring_single_heater
settings:
bend:
function: bend_euler
bend_coupler:
function: bend_euler
coupler_ring:
function: coupler_ring
cross_section:
bbox_layers: null
bbox_offsets: null
components_along_path: []
radius: 10.0
radius_min: 5.0
sections:
- hidden: false
insets: null
layer: WG
name: _default
offset: 0.0
offset_function: null
port_names:
- o1
- o2
port_types:
- optical
- optical
simplify: null
width: 0.5
width_function: null
cross_section_waveguide_heater: xs_sc_heater_metal
gap: 0.2
length_x: 4.0
length_y: 0.6
port_orientation: null
radius: 10.0
straight:
function: straight
via_stack:
function: via_stack
module: gdsfactory.components.via_stack
settings:
layers:
- - 11
- 0
- - 12
- 0
size:
- 10
- 10
vias:
- null
- null
via_stack_offset:
- 0
- 0
direction: top
layer: MTOP
orientation: 0
pad_array:
function: pad_array
module: gdsfactory.components.pad
settings:
pad:
function: pad
module: gdsfactory.components.pad
settings:
bbox_layers:
- - 13
- 0
bbox_offsets:
- -1.8
layer:
- 12
- 0
size:
- 75
- 75
spacing:
- 125
- 125
port_names: null
select_ports:
function: select_ports
module: gdsfactory.port
settings:
port_type: electrical
spacing:
- 0.0
- 100.0
component_name: null
cross_section: xs_sc
fanout_length: 0.0
gc_port_name: o1
get_input_labels_function:
function: get_input_labels
grating_coupler:
function: gc_te1550
layer_label:
- 10
- 0
optical_routing_type: 0
straight:
function: straight
with_loopback: false
15 changes: 3 additions & 12 deletions tests/test_components/test_pdk_settings_coupler_.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,6 @@ function: coupler
info:
length: 10.186
min_bend_radius: 11.857
module: gdsfactory.components.coupler
name: coupler
settings:
coupler_straight:
function: coupler_straight
coupler_symmetric:
function: coupler_symmetric
cross_section: xs_sc
dx: 10.0
dy: 4.0
gap: 0.236
length: 20.0
module: ubcpdk.components
name: coupler__ubcpdkpcomponents
settings: {}
18 changes: 3 additions & 15 deletions tests/test_components/test_pdk_settings_coupler_ring_.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,5 @@
function: coupler_ring
info: {}
module: gdsfactory.components.coupler_ring
name: coupler_ring
settings:
bend:
function: bend_euler
coupler90:
function: coupler90
coupler_straight:
function: coupler_straight
cross_section: xs_sc
cross_section_bend: null
gap: 0.2
length_extension: 3
length_x: 4.0
radius: 5.0
module: ubcpdk.components
name: coupler_ring__ubcpdkpcomponents
settings: {}
24 changes: 19 additions & 5 deletions tests/test_components/test_pdk_settings_dbr_cavity_.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,23 @@
function: dbr_cavity
function: cavity
info: {}
module: ubcpdk.components
name: dbr_cavity
module: gdsfactory.components.cavity
name: dbr_cavity_2afc46e9
settings:
component:
function: dbr
module: ubcpdk.components
settings:
cross_section:
function: cross_section
module: gdsfactory.cross_section
settings:
radius_min: 5
dw: 0.1
l1: 0.079406
l2: 0.079406
n: 100
w0: 0.5
coupler:
function: coupler
dbr:
function: dbr
gap: 0.2
length: 0.1
24 changes: 19 additions & 5 deletions tests/test_components/test_pdk_settings_dbr_cavity_te_.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,30 @@
function: add_fiber_array
info: {}
module: ubcpdk.components
name: add_fiber_array_add_fiber_array_componentdbr_cavity
name: add_fiber_array_add_fiber_array_d1dbd359
settings:
component:
function: dbr_cavity
module: ubcpdk.components
function: cavity
module: gdsfactory.components.cavity
settings:
component:
function: dbr
module: ubcpdk.components
settings:
cross_section:
function: cross_section
module: gdsfactory.cross_section
settings:
radius_min: 5
dw: 0.1
l1: 0.079406
l2: 0.079406
n: 100
w0: 0.5
coupler:
function: coupler
dbr:
function: dbr
gap: 0.2
length: 0.1
component_name: null
cross_section: xs_sc
fanout_length: 0.0
Expand Down
4 changes: 2 additions & 2 deletions tests/test_components/test_pdk_settings_ebeam_BondPad_.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function: ebeam_BondPad
function: ''
info:
library: Design kits/ebeam
model: ebeam_BondPad
module: ubcpdk.components
module: ''
name: ebeam_BondPad
settings: {}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function: ebeam_adiabatic_te1550
function: ''
info:
library: Design kits/ebeam
model: ebeam_adiabatic_te1550
module: ubcpdk.components
module: ''
name: ebeam_adiabatic_te1550
settings: {}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function: ebeam_adiabatic_tm1550
function: ''
info:
library: Design kits/ebeam
model: ebeam_adiabatic_tm1550
module: ubcpdk.components
module: ''
name: ebeam_adiabatic_tm1550
settings: {}
4 changes: 2 additions & 2 deletions tests/test_components/test_pdk_settings_ebeam_bdc_te1550_.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function: ebeam_bdc_te1550
function: ''
info:
library: Design kits/ebeam
model: ebeam_bdc_te1550
module: ubcpdk.components
module: ''
name: ebeam_bdc_te1550
settings: {}
4 changes: 2 additions & 2 deletions tests/test_components/test_pdk_settings_ebeam_bdc_tm1550_.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function: ebeam_bdc_tm1550
function: ''
info:
library: Design kits/ebeam
model: ebeam_bdc_tm1550
module: ubcpdk.components
module: ''
name: ebeam_bdc_tm1550
settings: {}
4 changes: 2 additions & 2 deletions tests/test_components/test_pdk_settings_ebeam_crossing4_.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function: ebeam_crossing4
function: ''
info:
library: Design kits/ebeam
model: ebeam_crossing4
module: ubcpdk.components
module: ''
name: ebeam_crossing4
settings: {}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function: ebeam_splitter_adiabatic_swg_te1550
function: ''
info:
library: Design kits/ebeam
model: ebeam_splitter_adiabatic_swg_te1550
module: ubcpdk.components
module: ''
name: ebeam_splitter_adiabatic_swg_te1550
settings: {}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function: ebeam_splitter_swg_assist_te1310
function: ''
info:
library: Design kits/ebeam
model: ebeam_splitter_swg_assist_te1310
module: ubcpdk.components
module: ''
name: ebeam_splitter_swg_assist_te1310
settings: {}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function: ebeam_splitter_swg_assist_te1550
function: ''
info:
library: Design kits/ebeam
model: ebeam_splitter_swg_assist_te1550
module: ubcpdk.components
module: ''
name: ebeam_splitter_swg_assist_te1550
settings: {}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function: ebeam_swg_edgecoupler
function: ''
info:
library: Design kits/ebeam
model: ebeam_swg_edgecoupler
module: ubcpdk.components
module: ''
name: ebeam_swg_edgecoupler
settings: {}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function: ebeam_terminator_te1310
function: ''
info:
library: Design kits/ebeam
model: ebeam_terminator_te1310
module: ubcpdk.components
module: ''
name: ebeam_terminator_te1310
settings: {}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function: ebeam_terminator_te1550
function: ''
info:
library: Design kits/ebeam
model: ebeam_terminator_te1550
module: ubcpdk.components
module: ''
name: ebeam_terminator_te1550
settings: {}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function: ebeam_terminator_tm1550
function: ''
info:
library: Design kits/ebeam
model: ebeam_terminator_tm1550
module: ubcpdk.components
module: ''
name: ebeam_terminator_tm1550
settings: {}
4 changes: 2 additions & 2 deletions tests/test_components/test_pdk_settings_ebeam_y_1550_.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
function: ebeam_y_1550
function: ''
info:
library: Design kits/ebeam
model: ebeam_y_1550
module: ubcpdk.components
module: ''
name: ebeam_y_1550
settings: {}
Loading
Loading