Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed 'required privilege' error (1314) on windows #36

Merged
merged 4 commits into from
May 8, 2022

Conversation

thomasdorch
Copy link
Contributor

On running instal_tech.py, the following error was occuring due to permissions issues with the os.symlink method:

OSError: [WinError 1314] A required privilege is not held by the client

Using subprocess.check_call creates a "junction" rather than a symlink and fixes this error.

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #36 (22eadbd) into master (826bdb8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   56.98%   56.98%           
=======================================
  Files          27       27           
  Lines         637      637           
=======================================
  Hits          363      363           
  Misses        274      274           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 826bdb8...22eadbd. Read the comment docs.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 7, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.64%.

Quality metrics Before After Change
Complexity 1.69 ⭐ 2.79 ⭐ 1.10 👎
Method Length 43.00 ⭐ 45.00 ⭐ 2.00 👎
Working memory 5.03 ⭐ 6.05 ⭐ 1.02 👎
Quality 86.43% 82.79% -3.64% 👎
Other metrics Before After Change
Lines 42 57 15
Changed files Quality Before Quality After Quality Change
install_tech.py 86.43% ⭐ 82.79% ⭐ -3.64% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joamatab
Copy link
Contributor

joamatab commented May 8, 2022

Awesome! thank you Thomas!

@joamatab joamatab merged commit ac82b0b into gdsfactory:master May 8, 2022
@thomasdorch thomasdorch deleted the fix_windows_install branch June 22, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants