Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update latest #316

Merged
merged 5 commits into from
Oct 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions .github/release-drafter.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
name-template: 'v$RESOLVED_VERSION'
tag-template: 'v$RESOLVED_VERSION'
template: |
# What's Changed

$CHANGES

**Full Changelog**: https://github.com/$OWNER/$REPOSITORY/compare/$PREVIOUS_TAG...v$RESOLVED_VERSION

categories:
- title: 'Breaking'
label: 'type: breaking'
- title: 'New'
label: 'type: feature'
- title: 'Bug Fixes'
label: 'type: bug'
- title: 'Maintenance'
label: 'type: maintenance'
- title: 'Documentation'
label: 'type: docs'
- title: 'Other changes'
- title: 'Dependency Updates'
label: 'type: dependencies'
collapse-after: 5

version-resolver:
major:
labels:
- 'type: breaking'
minor:
labels:
- 'type: feature'
patch:
labels:
- 'type: bug'
- 'type: maintenance'
- 'type: docs'
- 'type: dependencies'
- 'type: security'
default: patch

exclude-labels:
- 'skip-changelog'

exclude-contributors:
- 'joamatab'
33 changes: 0 additions & 33 deletions .github/workflows/build_mask.yml

This file was deleted.

35 changes: 35 additions & 0 deletions .github/workflows/release-drafter.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: Release Drafter

on:
push:
branches:
- main
# pull_request:
# types: [opened, reopened, synchronize]

permissions:
contents: read

jobs:
update_release_draft:
permissions:
# write permission is required to create a github release
contents: write
# write permission is required for autolabeler
# otherwise, read permission is required at least
pull-requests: write
runs-on: ubuntu-latest
steps:
# (Optional) GitHub Enterprise requires GHE_HOST variable set
#- name: Set GHE_HOST
# run: |
# echo "GHE_HOST=${GITHUB_SERVER_URL##https:\/\/}" >> $GITHUB_ENV

# Drafts your next Release notes as Pull Requests are merged into "master"
- uses: release-drafter/release-drafter@v5
# (Optional) specify config name to use, relative to .github/. Default: release-drafter.yml
# with:
# config-name: my-config.yml
# disable-autolabeler: true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Changelog

## [Unreleased](https://github.com/gdsfactory/ubc/compare/v2.1.0...main)
## [Unreleased](https://github.com/gdsfactory/ubc/compare/v2.1.1...main)

## [2.1.1](https://github.com/gdsfactory/ubc/compare/v2.1.0...v2.1.1)

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ classifiers = [
"Operating System :: OS Independent"
]
dependencies = [
"gdsfactory[cad]==7.8.1",
"gdsfactory[cad]==7.8.3",
"gplugins[tidy3d,sax,schematic]>=0.8.4,<0.9.0"
]
description = "ubcpdk pdk"
Expand Down
Binary file modified tests/ref/add_fiber_array_pads_rf.gds
Binary file not shown.
Binary file not shown.
Binary file not shown.
14 changes: 7 additions & 7 deletions tests/test_components/test_pdk_settings_add_fiber_array_.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: straight_add_fiber_array_c0aaeaa4_add_fiber_array
name: straight_add_fiber_array_35903362_add_fiber_array
settings:
changed: {}
child:
Expand All @@ -15,7 +15,7 @@ settings:
grating_coupler:
function: gc_te1550
layer_label:
- 66
- 10
- 0
optical_routing_type: 0
with_loopback: false
Expand Down Expand Up @@ -88,7 +88,7 @@ settings:
grating_coupler:
function: gc_te1550
layer_label:
- 66
- 10
- 0
optical_routing_type: 0
select_ports:
Expand All @@ -113,7 +113,7 @@ settings:
width: 0.5
info_version: 2
module: gdsfactory.routing.add_fiber_array
name: straight_add_fiber_array_c0aaeaa4
name: straight_add_fiber_array_35903362
default:
component:
function: straight
Expand All @@ -128,7 +128,7 @@ settings:
grating_coupler:
function: gc_te1550
layer_label:
- 66
- 10
- 0
optical_routing_type: 0
with_loopback: false
Expand All @@ -146,7 +146,7 @@ settings:
grating_coupler:
function: gc_te1550
layer_label:
- 66
- 10
- 0
optical_routing_type: 0
with_loopback: false
Expand All @@ -167,4 +167,4 @@ settings:
width: 0.5
info_version: 2
module: ubcpdk.components
name: straight_add_fiber_array_c0aaeaa4_add_fiber_array
name: straight_add_fiber_array_35903362_add_fiber_array
14 changes: 7 additions & 7 deletions tests/test_components/test_pdk_settings_dbr_cavity_te_.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: dbr_cavity_add_fiber_array_8a21ac4c_add_fiber_array_37b25c57
name: dbr_cavity_add_fiber_array_2f157efc_add_fiber_array_37b25c57
settings:
changed:
component:
Expand All @@ -17,7 +17,7 @@ settings:
grating_coupler:
function: gc_te1550
layer_label:
- 66
- 10
- 0
optical_routing_type: 0
with_loopback: false
Expand Down Expand Up @@ -97,7 +97,7 @@ settings:
grating_coupler:
function: gc_te1550
layer_label:
- 66
- 10
- 0
optical_routing_type: 0
select_ports:
Expand All @@ -114,7 +114,7 @@ settings:
wavelength: 1.55
info_version: 2
module: gdsfactory.routing.add_fiber_array
name: dbr_cavity_add_fiber_array_8a21ac4c
name: dbr_cavity_add_fiber_array_2f157efc
default:
component:
function: straight
Expand All @@ -129,7 +129,7 @@ settings:
grating_coupler:
function: gc_te1550
layer_label:
- 66
- 10
- 0
optical_routing_type: 0
with_loopback: false
Expand All @@ -146,7 +146,7 @@ settings:
grating_coupler:
function: gc_te1550
layer_label:
- 66
- 10
- 0
optical_routing_type: 0
with_loopback: false
Expand All @@ -159,4 +159,4 @@ settings:
wavelength: 1.55
info_version: 2
module: ubcpdk.components
name: dbr_cavity_add_fiber_array_8a21ac4c_add_fiber_array_37b25c57
name: dbr_cavity_add_fiber_array_2f157efc_add_fiber_array_37b25c57
10 changes: 6 additions & 4 deletions ubcpdk/components.py
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,8 @@ def dbr(
n: number of elements.
l1: length teeth1.
l2: length teeth2.
cross_section: spec.
kwargs: cross_section settings.
"""
c = gf.Component()

Expand Down Expand Up @@ -631,8 +633,8 @@ def dbr(


@gf.cell
def dbr_cavity(dbr=dbr, coupler=coupler) -> gf.Component:
dbr = gf.get_component(dbr)
def dbr_cavity(dbr=dbr, coupler=coupler, **kwargs) -> gf.Component:
dbr = dbr(**kwargs)
return gf.components.cavity(component=dbr, coupler=coupler)


Expand Down Expand Up @@ -749,7 +751,7 @@ def add_label_electrical(component: Component, text: str, port_name: str = "e2")
raise ValueError(f"No port {port_name!r} in {list(component.ports.keys())}")

component.add_label(
text=text, position=component.ports[port_name].center, layer=LAYER.LABEL
text=text, position=component.ports[port_name].center, layer=LAYER.TEXT
)
return component

Expand Down Expand Up @@ -814,5 +816,5 @@ def add_pads(


if __name__ == "__main__":
c = dbg(n=4)
c = add_fiber_array()
c.show(show_ports=True)
2 changes: 1 addition & 1 deletion ubcpdk/klayout/tech/layers.lyp
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@
<fill-color>#000000</fill-color>
<frame-brightness>0</frame-brightness>
<fill-brightness>0</fill-brightness>
<dither-pattern/>
<dither-pattern>I1</dither-pattern>
<line-style/>
<valid>true</valid>
<visible>true</visible>
Expand Down
1 change: 1 addition & 0 deletions ubcpdk/layers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ LayerViews:
layer: [99, 0]
layer_in_name: true
color: "black"
hatch_pattern: hollow
Lumerical:
layer: [733, 0]
width: 3
Expand Down
Empty file removed ubcpdk/samples/__init__.py
Empty file.
41 changes: 0 additions & 41 deletions ubcpdk/samples/test_masks.py

This file was deleted.

Loading