Fix DFT issue (Sourcery refactored)

[sourcery-ai]

Pull Request #181 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the 118 branch, then run:

git fetch origin sourcery/118
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Function dbr_cavity refactored with the following changes:

• Inline variable that is immediately returned (inline-immediately-returned-variable)

[sourcery-ai]

Function dbr_cavity_te refactored with the following changes:

• Inline variable that is immediately returned (inline-immediately-returned-variable)

[sourcery-ai]

Function add_fiber_array_pads_rf refactored with the following changes:

• Inline variable that is immediately returned (inline-immediately-returned-variable)

[sourcery-ai]

Function import_gc refactored with the following changes:

• Inline variable that is immediately returned (inline-immediately-returned-variable)

[sourcery-ai]

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics	Before	After	Change
Complexity	3.86 ⭐	3.86 ⭐	0.00
Method Length	43.47 ⭐	43.47 ⭐	0.00
Working memory	7.29 🙂	7.29 🙂	0.00
Quality	76.69% ⭐	76.69% ⭐	0.00%

Other metrics	Before	After	Change
Lines	883	883	0

Changed files	Quality Before	Quality After	Quality Change
ubcpdk/components.py	87.58% ⭐	87.58% ⭐	0.00%
ubcpdk/import_gds.py	57.19% 🙂	57.19% 🙂	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
ubcpdk/import_gds.py	add_ports_from_siepic_pins	18 🙂	282 ⛔	18 ⛔	26.57% 😞	Try splitting into smaller methods. Extract out complex expressions
ubcpdk/components.py	ebeam_dc_halfring_straight	1 ⭐	147 😞	15 😞	54.37% 🙂	Try splitting into smaller methods. Extract out complex expressions
ubcpdk/components.py	dbr	0 ⭐	115 🙂	12 😞	63.38% 🙂	Extract out complex expressions
ubcpdk/components.py	dbg	0 ⭐	81 🙂	12 😞	68.08% 🙂	Extract out complex expressions
ubcpdk/components.py	add_fiber_array	0 ⭐	44 ⭐	10 😞	77.45% ⭐	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!