Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gdsfactory #116

Merged
merged 6 commits into from
Nov 14, 2022
Merged

update gdsfactory #116

merged 6 commits into from
Nov 14, 2022

Conversation

joamatab
Copy link
Contributor

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 14, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 0.16 ⭐ 0.16 ⭐ 0.00
Method Length 26.75 ⭐ 26.75 ⭐ 0.00
Working memory 5.01 ⭐ 5.01 ⭐ 0.00
Quality 90.08% 90.08% 0.00%
Other metrics Before After Change
Lines 493 493 0
Changed files Quality Before Quality After Quality Change
ubcpdk/components.py 90.08% ⭐ 90.08% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
ubcpdk/components.py ebeam_dc_halfring_straight 1 ⭐ 148 😞 15 😞 54.26% 🙂 Try splitting into smaller methods. Extract out complex expressions
ubcpdk/components.py dbr 0 ⭐ 60 ⭐ 14 😞 68.29% 🙂 Extract out complex expressions
ubcpdk/components.py add_fiber_array 0 ⭐ 44 ⭐ 10 😞 77.45% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #116 (11214bc) into master (c0c3277) will decrease coverage by 0.07%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   60.51%   60.43%   -0.08%     
==========================================
  Files          18       18              
  Lines         509      508       -1     
==========================================
- Hits          308      307       -1     
  Misses        201      201              
Impacted Files Coverage Δ
ubcpdk/components.py 98.40% <0.00%> (-0.02%) ⬇️
ubcpdk/__init__.py 90.90% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 54603d6 into master Nov 14, 2022
@joamatab joamatab deleted the 190 branch November 14, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant