Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean layers in YAML #60

Merged
merged 2 commits into from
Feb 19, 2023
Merged

clean layers in YAML #60

merged 2 commits into from
Feb 19, 2023

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Feb 19, 2023

fixes #59

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 19, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.12%.

Quality metrics Before After Change
Complexity 0.03 ⭐ 0.06 ⭐ 0.03 👎
Method Length 1042.40 ⛔ 766.75 ⛔ -275.65 👍
Working memory 4.21 ⭐ 5.14 ⭐ 0.93 👎
Quality 63.94% 🙂 61.82% 🙂 -2.12% 👎
Other metrics Before After Change
Lines 1141 704 -437
Changed files Quality Before Quality After Quality Change
sky130/config.py 67.02% 🙂 66.36% 🙂 -0.66% 👎
sky130/layers.py 61.54% 🙂 61.56% 🙂 0.02% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
sky130/layers.py get_layer_stack 0 ⭐ 354 ⛔ 8 🙂 56.07% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Merging #60 (439bba3) into main (78b1456) will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   80.19%   80.20%           
=======================================
  Files          20       20           
  Lines        5676     5677    +1     
=======================================
+ Hits         4552     4553    +1     
  Misses       1124     1124           
Impacted Files Coverage Δ
sky130/layers.py 99.81% <75.00%> (ø)
sky130/config.py 96.77% <100.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 8a88e33 into main Feb 19, 2023
@joamatab joamatab deleted the 062 branch March 6, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom dither patterns not loading correctly
1 participant