Fixes remove partials #45
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
tests/test_netlists_si220.py
Outdated
| if not isinstance(func, partial): | ||
| if hasattr(func, "_base_cell"): | ||
| return | ||
| elif getattr(getattr(func, "__wrapped__", None), "__module__", "").startswith( | ||
| "cspdk" | ||
| ): | ||
| return | ||
| else: | ||
| raise ValueError(f"Cell {name!r} does not belong to pdk.") |
There was a problem hiding this comment.
issue (code-quality): Avoid conditionals in tests. (no-conditionals-in-tests)
Explanation
Avoid complex code, like conditionals, in test functions.Google's software engineering guidelines says:
"Clear tests are trivially correct upon inspection"
To reach that avoid complex code in tests:
- loops
- conditionals
Some ways to fix this:
- Use parametrized tests to get rid of the loop.
- Move the complex logic into helpers.
- Move the complex part into pytest fixtures.
Complexity is most often introduced in the form of logic. Logic is defined via the imperative parts of programming languages such as operators, loops, and conditionals. When a piece of code contains logic, you need to do a bit of mental computation to determine its result instead of just reading it off of the screen. It doesn't take much logic to make a test more difficult to reason about.
Software Engineering at Google / Don't Put Logic in Tests
tests/test_netlists_si220.py
Outdated
| if hasattr(func, "_base_cell"): | ||
| return | ||
| elif getattr(getattr(func, "__wrapped__", None), "__module__", "").startswith( | ||
| "cspdk" | ||
| ): | ||
| return | ||
| else: | ||
| raise ValueError(f"Cell {name!r} does not belong to pdk.") |
There was a problem hiding this comment.
issue (code-quality): Avoid conditionals in tests. (no-conditionals-in-tests)
Explanation
Avoid complex code, like conditionals, in test functions.Google's software engineering guidelines says:
"Clear tests are trivially correct upon inspection"
To reach that avoid complex code in tests:
- loops
- conditionals
Some ways to fix this:
- Use parametrized tests to get rid of the loop.
- Move the complex logic into helpers.
- Move the complex part into pytest fixtures.
Complexity is most often introduced in the form of logic. Logic is defined via the imperative parts of programming languages such as operators, loops, and conditionals. When a piece of code contains logic, you need to do a bit of mental computation to determine its result instead of just reading it off of the screen. It doesn't take much logic to make a test more difficult to reason about.
Software Engineering at Google / Don't Put Logic in Tests
tests/test_netlists_si220.py
Outdated
| while isinstance(func, partial): | ||
| func = func.func |
There was a problem hiding this comment.
issue (code-quality): Avoid loops in tests. (no-loop-in-tests)
Explanation
Avoid complex code, like loops, in test functions.Google's software engineering guidelines says:
"Clear tests are trivially correct upon inspection"
To reach that avoid complex code in tests:
- loops
- conditionals
Some ways to fix this:
- Use parametrized tests to get rid of the loop.
- Move the complex logic into helpers.
- Move the complex part into pytest fixtures.
Complexity is most often introduced in the form of logic. Logic is defined via the imperative parts of programming languages such as operators, loops, and conditionals. When a piece of code contains logic, you need to do a bit of mental computation to determine its result instead of just reading it off of the screen. It doesn't take much logic to make a test more difficult to reason about.
Software Engineering at Google / Don't Put Logic in Tests
tests/test_netlists_si500.py
Outdated
| if not isinstance(func, partial): | ||
| if hasattr(func, "_base_cell"): | ||
| return | ||
| elif getattr(getattr(func, "__wrapped__", None), "__module__", "").startswith( | ||
| "cspdk" | ||
| ): | ||
| return | ||
| else: | ||
| raise ValueError(f"Cell {name!r} does not belong to pdk.") |
There was a problem hiding this comment.
issue (code-quality): Avoid conditionals in tests. (no-conditionals-in-tests)
Explanation
Avoid complex code, like conditionals, in test functions.Google's software engineering guidelines says:
"Clear tests are trivially correct upon inspection"
To reach that avoid complex code in tests:
- loops
- conditionals
Some ways to fix this:
- Use parametrized tests to get rid of the loop.
- Move the complex logic into helpers.
- Move the complex part into pytest fixtures.
Complexity is most often introduced in the form of logic. Logic is defined via the imperative parts of programming languages such as operators, loops, and conditionals. When a piece of code contains logic, you need to do a bit of mental computation to determine its result instead of just reading it off of the screen. It doesn't take much logic to make a test more difficult to reason about.
Software Engineering at Google / Don't Put Logic in Tests
tests/test_netlists_si500.py
Outdated
| if hasattr(func, "_base_cell"): | ||
| return | ||
| elif getattr(getattr(func, "__wrapped__", None), "__module__", "").startswith( | ||
| "cspdk" | ||
| ): | ||
| return | ||
| else: | ||
| raise ValueError(f"Cell {name!r} does not belong to pdk.") |
There was a problem hiding this comment.
issue (code-quality): Avoid conditionals in tests. (no-conditionals-in-tests)
Explanation
Avoid complex code, like conditionals, in test functions.Google's software engineering guidelines says:
"Clear tests are trivially correct upon inspection"
To reach that avoid complex code in tests:
- loops
- conditionals
Some ways to fix this:
- Use parametrized tests to get rid of the loop.
- Move the complex logic into helpers.
- Move the complex part into pytest fixtures.
Complexity is most often introduced in the form of logic. Logic is defined via the imperative parts of programming languages such as operators, loops, and conditionals. When a piece of code contains logic, you need to do a bit of mental computation to determine its result instead of just reading it off of the screen. It doesn't take much logic to make a test more difficult to reason about.
Software Engineering at Google / Don't Put Logic in Tests
tests/test_netlists_sin300.py
Outdated
| if not isinstance(func, partial): | ||
| if hasattr(func, "_base_cell"): | ||
| return | ||
| elif getattr(getattr(func, "__wrapped__", None), "__module__", "").startswith( | ||
| "cspdk" | ||
| ): | ||
| return | ||
| else: | ||
| raise ValueError(f"Cell {name!r} does not belong to pdk.") |
There was a problem hiding this comment.
issue (code-quality): Avoid conditionals in tests. (no-conditionals-in-tests)
Explanation
Avoid complex code, like conditionals, in test functions.Google's software engineering guidelines says:
"Clear tests are trivially correct upon inspection"
To reach that avoid complex code in tests:
- loops
- conditionals
Some ways to fix this:
- Use parametrized tests to get rid of the loop.
- Move the complex logic into helpers.
- Move the complex part into pytest fixtures.
Complexity is most often introduced in the form of logic. Logic is defined via the imperative parts of programming languages such as operators, loops, and conditionals. When a piece of code contains logic, you need to do a bit of mental computation to determine its result instead of just reading it off of the screen. It doesn't take much logic to make a test more difficult to reason about.
Software Engineering at Google / Don't Put Logic in Tests
tests/test_netlists_sin300.py
Outdated
| if hasattr(func, "_base_cell"): | ||
| return | ||
| elif getattr(getattr(func, "__wrapped__", None), "__module__", "").startswith( | ||
| "cspdk" | ||
| ): | ||
| return | ||
| else: | ||
| raise ValueError(f"Cell {name!r} does not belong to pdk.") |
There was a problem hiding this comment.
issue (code-quality): Avoid conditionals in tests. (no-conditionals-in-tests)
Explanation
Avoid complex code, like conditionals, in test functions.Google's software engineering guidelines says:
"Clear tests are trivially correct upon inspection"
To reach that avoid complex code in tests:
- loops
- conditionals
Some ways to fix this:
- Use parametrized tests to get rid of the loop.
- Move the complex logic into helpers.
- Move the complex part into pytest fixtures.
Complexity is most often introduced in the form of logic. Logic is defined via the imperative parts of programming languages such as operators, loops, and conditionals. When a piece of code contains logic, you need to do a bit of mental computation to determine its result instead of just reading it off of the screen. It doesn't take much logic to make a test more difficult to reason about.
Software Engineering at Google / Don't Put Logic in Tests
tests/test_netlists_sin300.py
Outdated
| while isinstance(func, partial): | ||
| func = func.func |
There was a problem hiding this comment.
issue (code-quality): Avoid loops in tests. (no-loop-in-tests)
Explanation
Avoid complex code, like loops, in test functions.Google's software engineering guidelines says:
"Clear tests are trivially correct upon inspection"
To reach that avoid complex code in tests:
- loops
- conditionals
Some ways to fix this:
- Use parametrized tests to get rid of the loop.
- Move the complex logic into helpers.
- Move the complex part into pytest fixtures.
Complexity is most often introduced in the form of logic. Logic is defined via the imperative parts of programming languages such as operators, loops, and conditionals. When a piece of code contains logic, you need to do a bit of mental computation to determine its result instead of just reading it off of the screen. It doesn't take much logic to make a test more difficult to reason about.
Software Engineering at Google / Don't Put Logic in Tests
| pdk = Pdk( | ||
| name="cornerstone_si500", | ||
| cells=_cells, | ||
| cross_sections=_cross_sections, # type: ignore | ||
| layers=LAYER, | ||
| layer_stack=LAYER_STACK, | ||
| layer_views=LAYER_VIEWS, | ||
| models=_models, | ||
| routing_strategies=routing_strategies, | ||
| ) |
There was a problem hiding this comment.
issue (code-quality): Inline variable that is immediately returned (inline-immediately-returned-variable)
| pdk = Pdk( | ||
| name="cornerstone_sin300", | ||
| cells=_cells, | ||
| cross_sections=_cross_sections, # type: ignore | ||
| layers=LAYER, | ||
| layer_stack=LAYER_STACK, | ||
| layer_views=LAYER_VIEWS, | ||
| models=_models, | ||
| routing_strategies=routing_strategies, | ||
| ) |
There was a problem hiding this comment.
issue (code-quality): Inline variable that is immediately returned (inline-immediately-returned-variable)
|
looks good, thanks Joaquin! it looks like there are still a few cells that still use partials or this |
|
i finished removing the base_cell wrapper |
No description provided.