Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better values for cross_section #39

Merged
merged 2 commits into from
May 17, 2024
Merged

better values for cross_section #39

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
053f0c2
better values
joamatab May 17, 2024
057ab93
update readme
joamatab May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cspdk/si220/cells.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,6 +1038,7 @@ def mzi_sc(
length_y: float = 2.0,
length_x: float = 0.1,
add_electrical_ports_bot: bool = True,
cross_section: CrossSectionSpec = "xs_sc",
**kwargs,
) -> gf.Component:
"""A Mach-Zehnder Interferometer (MZI) in strip, c-band.
Expand All @@ -1051,8 +1052,6 @@ def mzi_sc(
Returns:
gf.Component: the component
"""
if "cross_section" not in kwargs:
kwargs["cross_section"] = "xs_sc"
return _mzi(
delta_length=delta_length,
length_y=length_y,
Expand All @@ -1062,6 +1061,7 @@ def mzi_sc(
bend=bend_sc,
combiner=mmi1x2_sc,
splitter=mmi1x2_sc,
cross_section=cross_section,
**kwargs,
)

Expand Down Expand Up @@ -1478,7 +1478,7 @@ def crossing_sc() -> gf.Component:


if __name__ == "__main__":
c = die_sc()
c = mzi_sc()
# c = crossing_sc()
c.show()
# for name, func in list(globals().items()):
Expand Down
2 changes: 1 addition & 1 deletion cspdk/si220/samples/circuit_simulations_sc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from cspdk.si220 import PDK, cells

if __name__ == "__main__":
c = cells.mzi_sc(delta_length=100)
c = cells.mzi_sc(delta_length=50)
c.show()
c.plot_netlist()
netlist = c.get_netlist()
Expand Down
Loading