feat: remove Job interface #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
- Coverage 96.66% 95.73% -0.94%
==========================================
Files 7 7
Lines 660 656 -4
==========================================
- Hits 638 628 -10
- Misses 18 24 +6
Partials 4 4
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Closed
Closed
janrnc
force-pushed
the
feat/remove-job-interface
branch
from
fcf9e70 to
83de230
Compare
janrnc
force-pushed
the
feat/remove-job-interface
branch
from
83de230 to
d56396c
Compare
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jobinterface and used simplefunc()instead. Access to external variables or struct properties is still possible using closures.cron.AddFunc().cron.AddJob()renamed tocron.Add(), taking in this newfunc()job.JobandWrappedJobfromEntrywhich made it possible to inspect the scheduledJobstruct. Now that jobs arefunc()s, this is no longer relevant. Job struct management is up to the user who's free to map them to the cron IDs in the preferred way.