-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pyproject.toml
and poetry
#180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is recommended to include a `requirements.txt` file in your library to specify the versions of dependencies with which the library has been tested.
Based on Ruff linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR converts the previous
setup.py
implementation to the current standard of usingpyproject.toml
usingpoetry
. For this all dependencies originally found within therequirements
directory have been included as individual groups (e.g.dev
,tests
etc.). Furthermore, therequirements.txt
file has been updated to include the dependencies with which the tests have been run, following the argument in this StackOverflow answer. Last but not least, abuild.yml
workflow has been added to test the library's build status and a publishing workflowpublish.yml
to publish on release automatically.This PR also adds a linting workflow based on Ruff which implements
flake8
andblack
rules. The pre-commit hook has also been modified to useruff
for linting and format checks. Ruff is much faster and the pre-commit hooks finish almost instantly - We love performance, don't we? 🤓TLDR
setup.py
topyproject.toml
build.yml
workflow to test build statuslint.yml
workflow forruff
lintingruff
to pre-commit hooksToDo's
dev
group.Add workflow to test publishing at Test PyPI (access is required)Independent of this PR