-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Screen.ChannelEvents v2 #465
Conversation
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
==========================================
- Coverage 16.10% 15.44% -0.66%
==========================================
Files 21 22 +1
Lines 1472 1580 +108
==========================================
+ Hits 237 244 +7
- Misses 1221 1322 +101
Partials 14 14
Continue to review full report at Codecov.
|
I have simplified the implementation from before, and I have added tests too. Now the only potential problem is what happens when you call PollEvent while ChannelEvents is running. |
I wouldn't worry about that problem. We should just document that two are incompatible. |
I don't understand how just changing a doc comment reduces test coverage. |
Thanks for your contribution! |
This PR proposes an alternative API for getting Events. Version 2. The following method is added:
Previous version: #461.